[cleanup] Fix EOL encoding for toolFilterNPE.odesign

Change-Id: Ifc62e42dcf259fd2f38bc8b599222249ad058fae
[439871] Remove UI dependencies which are not actually used

Bug: 439871
Change-Id: I69dcb3546c3da1c4a4d2b15509b9e866c32aaabb
Signed-off-by: Cedric Brun <cedric.brun@obeo.fr>
[439871] Stop using LabelProvider the Table dialect

EMF introduced IItemLabelProvider exactly for this need: to avoid
depending on UI stuffs just to retrieve a label. This commit makes the
refresh use directly the IItemLabelProvider instead of wrapping it into
a useless labelprovider.

Bug: 439871
Change-Id: I75ecf4081cc50243ee3ce90276f9cae8ed1a4130
Signed-off-by: Cedric Brun <cedric.brun@obeo.fr>
[439871] Add a default SelectorProvider

This provider is available when nothing else is contributed so that the
corresponding code will work nonetheless, but it is expected to be
overriden by the one in org.eclipse.sirius.ui.

Bug: 439871
Change-Id: Id8631a36aac090f8a786b590a2c364c6adccc23c
Signed-off-by: Cedric Brun <cedric.brun@obeo.fr>
[test] Improve stability of SequenceLifelineTest

Change-Id: I8359fcb304245b695e3038650deb5369b3f34c48
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
[439871] Move the diagram refresh logic down to the non-ui plug-in

Move the DiagramDialect and all the code it depends on into the
core (non-ui) diagram plug-in.

The CanonicalSynchronizer implementation (DDiagramCanonicalSynchronizer)
is still defined in the ui, but invoked from the core through the new
canonicalSynchronizerFactoryOverride extension point.

Also move the ViewpointSelectionCallback logic in a dedicated class in
the core plug-in, delegating from the old one.

Bug: 439871
Change-Id: I06f70d0264231ef364163f42cfbb49d2e6055bdb
Signed-off-by: Cedric Brun <cedric.brun@obeo.fr>
[442289] Fix wrongly enablement status depending on selection

This commit fix the problem detected in bug 446124.

Bug: 442289
Change-Id: I19668a20a4219a3c6aafa2cd25dafe3d54908a19
Signed-off-by: Laurent Redor <laurent.redor@obeo.fr>
[test] Change SNAPTOGRID and SNAPTOGEOMETRY values in UI thread.

RulerGridPropertySection.PropertyStoreListener is notified when these
GMF properties are changed. It needs to be executed in UI Thread. To
avoid "SWTException: Invalid thread access", the changes of
WorkspaceViewerProperties.SNAPTOGRID and
WorkspaceViewerProperties.SNAPTOGEOMETRY are now made in UI thread.
   
Change-Id: I110b7fa82d374ffaa7250a2b2b4a2a44a67ef2ce
Signed-off-by: Laurent Redor <laurent.redor@obeo.fr>
[cleanup] Use API to open representation instead of using UI.

Using UI, ie browsing in the model explorer and clicking on contextual
menu, is slower and less reliable that directly using the API to open a
representation of a session.

* Automatically replace

diagram =
localSession\.getLocalSessionBrowser\(\)\.perCategory\(\)\.selectViewpoint\((?:[^\)]*)\)\.selectRepresentation\(([^\)]*)\)(?:[^\.]*)\.selectDiagramInstance\(([^\)]*)\)\.open\(\);(?:[^e]*)editor
= diagram\.getEditor\(\);

and

diagram =
localSession\.getLocalSessionBrowser\(\)\.perCategory\(\)\.selectViewpoint\((?:[^\)]*)\)\.selectRepresentation\(([^\)]*)\)(?:[^\.]*)\.selectRepresentationInstance\(([^,]*),\sUIDiagramRepresentation\.class\)\.open\(\);(?:[^e]*)editor
= diagram\.getEditor\(\);

by editor = (SWTBotSiriusDiagramEditor)
openRepresentation(localSession.getOpenedSession(), $1, $2,
DDiagram.class);

* and some other manual changes

Change-Id: Ib80d87c3f3529ed8a8892470b41cdb3a07d7e4ce
Signed-off-by: Laurent Redor <laurent.redor@obeo.fr>
[439871] Remove the dependency from table to JFace

It is not needed anymore since the recent change in the label
provider (see I75ecf4081cc50243ee3ce90276f9cae8ed1a4130).

Bug: 439871
Change-Id: Id193a6eef3491d8b64bfeb999b5009c192e6230f
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
[439871] Avoid depending on Draw2D for a trivial geometric computation

Bug: 439871
Change-Id: If0b41bdea93af612bb1930d7b405a681f5a2fdc1
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>