p2 working. need to set up params