fix array overflow issues found by David A.

Issues reported at
https://hypernews.cern.ch/HyperNews/CMS/get/swReleases/4108/1/1/1/1/1/1/1/1.html
and follow ups are mostly fixed here. 
yes indeed. The code can be optimized considerably (I got rid of 75% of the abs-s in this part of the code but didn't go further)

On Sep 14, 2014, at 7:33 PM, StoyanStoynev <notifications@github.com> wrote:

> In RecoEcal/EgammaCoreTools/plugins/EcalClusterEnergyUncertaintyObjectSpecific.cc:
> 
> > @@ -220,7 +222,7 @@ float EcalClusterEnergyUncertaintyObjectSpecific::getValue( const reco::SuperClu
> >  	  }													       								 
> >  	}
> >  	
> > -	if (TMath::Abs(eta)>2.5) iEtaSl = nBinsEta-1;
> > +	if (absEta>EtaBins[nBinsEta-1]) iEtaSl = nBinsEta-1;
> >  	if (brem<BremBins[0]) iBremSl = 0;
> >  	if (brem>BremBins[nBinsBrem-1]) iBremSl = nBinsBrem-1;
> 
> It's a bug fix but:
> iEtaSl could have been initialized as nBinsEta-1 (given EtaBins[0] = 0), loop to nBinsEta-2 above and not bother at all here. Similar for brem (second line). Last bin of EtaBins[] and BremBins[] is then not needed.
> 
> —
> Reply to this email directly or view it on GitHub.
>