I understand and agree. Considering this the changes should be moved to
 EucNodeDriver (which is currently mostly a stub).
This would require also changing the create_node method from
BaseEC2NodeDriver so we can update the params dictionary from EucNodeDriver.

Marian

On Mon, Feb 3, 2014 at 4:04 PM, Tomaz Muraus <notifications@github.com>wrote:

> In libcloud/compute/drivers/ec2.py:
>
> > @@ -1383,6 +1383,12 @@ def create_node(self, **kwargs):
> >              else:
> >                  params['IamInstanceProfile.
> Name'] = kwargs['ex_iamprofile']
> >
> > +        if 'ex_addressingtype' in kwargs and kwargs['ex_addressingtype'] not in ["private", "public"]:
> > +            raise AttributeError('Unsupported addressing type')
> > +
> > +        if 'ex_addressingtype' in kwargs:
> > +            params['AddressingType'] = kwargs["ex_addressingtype"]
>
> The reason I'm asking is that because if it's only supported by Eucalyptus
> it should live in the Eucalyptus driver.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/apache/libcloud/pull/243/files#r9383133>
> .
>