So this is a bit orthogonal to this change - which has freedom respond to
the caller with a promise.

We can talk about what the provider api should be, and maybe promises are
good there for consistency, but that's a different refactor.
On Feb 18, 2014 5:06 PM, "Serene H" <notifications@github.com> wrote:

> In providers/storage/isolated/storage.isolated.js:
>
> > @@ -54,7 +53,7 @@ IsolatedStorageProvider.prototype.get = function(key, continuation) {
> >    }
> >
> >    var promise = this.store.get(this.toStoredKey(key));
> > -  promise.done(continuation);
> > +  promise.then(continuation);
> >  };
> >
> >  IsolatedStorageProvider.prototype.set = function(key, value, continuation) {
>
> Are you planning to phase out the continuation-passing style? In the
> promise paradigm, functions return the promise, so that the users of the
> function can do .then() from there instead of passing in a continuation :)
>
> --
> Reply to this email directly or view it on GitHub<https://github.com/UWNetworksLab/freedom/pull/45/files#r9850281>
> .
>