better handle NetworkParameters in Address

 to allow other kind of networks that are not defined in the library.
My apologies I misread the change (code taken out —).
I thought you didn’t simply return the params.

On 10 Sep 2014, at 14:53, Giannis Dzegoutanis <notifications@github.com> wrote:

> In core/src/main/java/com/google/bitcoin/core/Address.java:
> 
> >      public NetworkParameters getParameters() {
> > -        // TODO: There should be a more generic way to get all supported networks.
> > -        NetworkParameters[] networks = { TestNet3Params.get(), MainNetParams.get() };
> > -        for (NetworkParameters params : networks) {
> > -            if (isAcceptableVersion(params, version)) {
> > -                return params;
> > -            }
> > -        }
> > -        return null;
> > +        return params;
> I think it was the case, as no tests failed. The idea here is to always have a not null NetworkParameters and anything unrecognizable will fail.
> 
> —
> Reply to this email directly or view it on GitHub.
>