Yep, that would certainly increase the readability of the code, I totally agree!

 Taking kolmogorov into account in the near future, I may want to have something that includes some of these parameters in the  wavefrontParameters vector. Then the wfg() can check what names are existent and know what to create.

----- Reply message -----
From: "João Lopes e Silva" <notifications@github.com>
To: "faitdivers/pyao" <pyao@noreply.github.com>
Cc: "larsvl" <larsvl@live.nl>
Subject: [pyao] WFG (#44)
Date: Sat, May 31, 2014 18:36


> @@ -90,7 +98,7 @@ def runClosedLoop():
>
>       for i in range(0, iterations):
>               print("Running simulation step %d" % (i));
> -             wf = wfg(sensorParameters);
> +             wf = wfg(sensorParameters, wavefrontParameters['zernikeModes'], wavefrontParameters['zernikeWeights'])

perhaps pass the full wavefrontParameters? You're going to need more parameters afterwards

---
Reply to this email directly or view it on GitHub:
https://github.com/faitdivers/pyao/pull/44/files#r13261977