When it was a class method it needed an id. I won't be needed once it is an
instance method.


2014-06-02 12:13 GMT-06:00 Daniel McDonald <notifications@github.com>:

> In qiita_db/base.py:
>
> > @@ -80,7 +80,7 @@ def __init__(self, id_):
> >          self._id = id_
> >
> >      def __eq__(self, other):
> > -        return other._id == self._id
> > +        return other._id == self._id and type(self) == type(other)
>
> that seems reasonable, is there a need to pass an `_id` to `delete`?
> … <#1465dc9952698c34_>
> On Mon, Jun 2, 2014 at 12:06 PM, josenavas <notifications@github.com>
> wrote: In qiita_db/base.py: > @@ -80,7 +80,7 @@ def __init__(self, id_): >
> self._id = id_ > > def __eq__(self, other): > - return other._id ==
> self._id > + return other._id == self._id and type(self) == type(other)
> This way, de delete functions won't need to get an id, they will get them
> from the instance. — Reply to this email directly or view it on GitHub <
> https://github.com/biocore/qiita/pull/67/files#r13298288>.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/biocore/qiita/pull/67/files#r13298667>.
>



-- 
Jose Navas