added types to attributes