Code cleanup


EntryIDSet.java:
Removed unused code.

git-svn-id: https://svn.forgerock.org/opendj/branches/opendj3-server-dev@11516 41b1ffd8-f28e-4786-ab96-9950f0a78031
Improved code readability.


BaseDnRegistry.java:
In registerBaseDN(), extracted method getSuperiorBackend().

git-svn-id: https://svn.forgerock.org/opendj/branches/opendj3-server-dev@11517 41b1ffd8-f28e-4786-ab96-9950f0a78031
Fixed typos + formatting

git-svn-id: https://svn.forgerock.org/opendj/branches/opendj3-server-dev@11518 41b1ffd8-f28e-4786-ab96-9950f0a78031
Fix OPENDJ-1709: Persistit: ldapsearch returns second entry twice

Manually reviewed by Jean-Noel.

* fix Persistit storage cursor iteration. Application code which uses the cursor API assumes that calling next() after a call to positionXXX() moves the cursor forward
* fix various places where we were using stale key/value references
* fix a couple of minor bugs when checking the result of cursoring in VLV indexing.


git-svn-id: https://svn.forgerock.org/opendj/branches/opendj3-server-dev@11520 41b1ffd8-f28e-4786-ab96-9950f0a78031
OPENDJ-1707 Persistit: various import problems
Code review: Matthew Swift

Added support for merge/replace of entries.


RootContainer.java:
In importLDIF():
- simplified the logic for removing database files: got rid of JE legacy code
- when adding entries, supported replacing entries if config permits

EntryContainer.java:
Better exception handling / respect declared exceptions.

git-svn-id: https://svn.forgerock.org/opendj/branches/opendj3-server-dev@11521 41b1ffd8-f28e-4786-ab96-9950f0a78031
OPENDJ-1707 Persistit: various import problems

Output import progress + final import stats.


pluggable.RootContainer.java
Added ImportProgress inner class.
In importLDIF(), added import progress + final import stats.

jeb*.properties, jeb.Importer.java:
In NOTE_JEB_IMPORT_PROGRESS_REPORT_96, removed unused "migrated entries".

git-svn-id: https://svn.forgerock.org/opendj/branches/opendj3-server-dev@11522 41b1ffd8-f28e-4786-ab96-9950f0a78031
NotImplementedException.java: REMOVED

RootContainer.java:
Replaced the use of NotImplementedException with UnsupportedOperationException.

git-svn-id: https://svn.forgerock.org/opendj/branches/opendj3-server-dev@11523 41b1ffd8-f28e-4786-ab96-9950f0a78031
Storage.java:
In read() and write(), renamed the parameters to match their type.

git-svn-id: https://svn.forgerock.org/opendj/branches/opendj3-server-dev@11524 41b1ffd8-f28e-4786-ab96-9950f0a78031
OPENDJ-1710: NPE performing deletes and potentially other indexed updates against Persistit backend

* inline and simplify ID list encoding avoiding potential NPEs
* fix usage of stale key in EntryContainer.deleteEntry().

It is now possible to do single entry deletes. Subtree deletes fail when attempting to delete the final top level entry.


git-svn-id: https://svn.forgerock.org/opendj/branches/opendj3-server-dev@11525 41b1ffd8-f28e-4786-ab96-9950f0a78031
OPENDJ-1710: NPE performing deletes and potentially other indexed updates against Persistit backend

Minor code cleanup:

* replace uses of ByteSequence.COMPARATOR with ByteSequence.compareTo()
* simplify cursoring over ranges (consequence of above change)
* remove unnecessary unnecessary loops for initial positioning of cursors.


git-svn-id: https://svn.forgerock.org/opendj/branches/opendj3-server-dev@11526 41b1ffd8-f28e-4786-ab96-9950f0a78031
OPENDJ-1710: NPE performing deletes and potentially other indexed updates against Persistit backend

Reentrant accesses to dn2id during subtree delete were interfering with the cursor's position, causing it to delete the wrong records. Avoid interference by acquiring a per-cursor exchange.


git-svn-id: https://svn.forgerock.org/opendj/branches/opendj3-server-dev@11527 41b1ffd8-f28e-4786-ab96-9950f0a78031
Fix formatting in PersistItStorage.java


git-svn-id: https://svn.forgerock.org/opendj/branches/opendj3-server-dev@11528 41b1ffd8-f28e-4786-ab96-9950f0a78031