fix params, add test