Remove trailing whitespace
Merge pull request #47 from alphagov/remove-whitespace

Remove trailing whitespace
Remove unused @test_config from vapp_template_spec

This isn't used in the tests so remove it.
Rename catalog_item->vapp_template in config tests

These tests have no functional relation to Vcloud::Core::VappTemplate
because they only test config in/out. But they should be consistent with the
renaming about to occur in that class and vcloud-launcher.
Change arguments for VappTemplate#get

Swap the order of the template and catalog arguments so that they match the
`#get_ids_by_name_and_catalog` method, which can't easily be changed because
the order is reflected in the method name, and besides it reads more
naturally this way round - you want to get a specific item (first, can never
be a default) from a broader collection (second, could be a default catalog).

We temporarily decided not to so this because it means a matching version
change in vcloud-launcher. But we'll be releasing feature changes to schema
validation, so we might as well do this now.

Renaming `catalog_item_name` to `vapp_template_name` to match renaming about
to occur in vcloud-launcher. I'm not very attached to the `vapp_template_`
prefix because we're already in the VappTemplate class.
Remove Fog::ServiceInterface.get_[item_]catalog

These are no longer used by Vcloud::Core as of ba146c9. None of the other
tools use these methods either.
Remove Fog::ContentTypes::CATALOG[_ITEM]

These are no longer used by Vcloud::Core as of ba146c9. None of the other
tools use these consts either.
Increase test coverage threshold to 81%

We currently have 83.5% coverage. So increase by 10%.
Merge pull request #51 from alphagov/increase_coverage_81pc

Increase test coverage threshold to 81%
Merge pull request #49 from alphagov/70452106-rename_vapptemplate_catalog_item

[#70452106] Change arguments for VappTemplate#get
Support warnings for ConfigValidator

These are less extreme than errors in that they don't fail validation. The
first use case will be schema deprecations, whereby one param replaces
another.

The consumer will need to check for them with `warnings.empty?`. I'm not
sure it's worth providing a `#warnings?` method equivalent to `#valid?` and
`#errors`.
Support schema deprecations in ConfigValidator

The renaming of `catalog_item` to `vapp_template` in vcloud-launcher has
exposed the need for parameter deprecations in schemas. Because one or the
other is required, but not both, and a warning should be raised if the old
param is provided.

This is only supported in the simplest case where the two parameters exist
at the same nesting level in the schema. We omit the `required` checking for
deprecated params (if they're not provided) because we don't want to
complain about both params.