adding attributes and ginore