I think we should.  And definitely we should use spaces and not tabs; all IDEs allow you use use spaces instead of tabs.  Also, is anybody updating our src/.idea as we change the conventions?

I see that the instructions in the src/README file are for Eclipse.  Shouldn't we change them to be for ItelliJ?  I think we have no Eclipse developers at this moment.  Even I started to use IntelliJ (two days ago :)).

Grigore


________________________________
From: dwightguth [notifications@github.com]
Sent: Tuesday, March 04, 2014 3:22 PM
To: kframework/k
Subject: Re: [k] New parser. Adding NullabilityCheck. (First pull request). (#267)


In src/javasources/KTool/src/org/kframework/parser/concrete2/Parser.java:

> @@ -399,12 +399,12 @@ public int hashCode() {
>      Map<StateReturn.Key,StateReturn> stateReturns = new HashMap<StateReturn.Key,StateReturn>();
>
>      public NonTerminalCall getNtCall(NonTerminalCall.Key key) {
> -            NonTerminalCall value = ntCalls.get(key);
> -            if (value == null) {
> -                    value = new NonTerminalCall(key);
> -                    ntCalls.put(key, value);
> -            }
> -            return value;
> +        NonTerminalCall value = ntCalls.get(key);
> +        if (value == null) {
> +                value = new NonTerminalCall(key);
> +                ntCalls.put(key, value);
> +        }
> +        return value;


Okay. Well you changed it from having 8-space indents to having a mixture of 8-space indents and 4-space indents. I'm okay with having a code policy of only 4-space indents, but in that case you need to change it the rest of the way, and then we need to change the rest of the codebase and implement a checkstyle policy. Otherwise we're going to be having stuff like this happen all the time. Personally I'd prefer to avoid going to that extreme, but there's no middle ground here. Either we insist on an indentation policy or we don't.

—
Reply to this email directly or view it on GitHub<https://github.com/kframework/k/pull/267/files#r10275269>.