Thanks for the feedback. I removed the new variables and add the CLI support.
The change is now pushed to the naarad.

Thanks,
-Joy

From: Ritesh Maheshwari <notifications@github.com<mailto:notifications@github.com>>
Reply-To: linkedin/naarad <reply@reply.github.com<mailto:reply@reply.github.com>>
Date: Friday, April 11, 2014 at 9:49 AM
To: linkedin/naarad <naarad@noreply.github.com<mailto:naarad@noreply.github.com>>
Cc: Chaoyue Xiong <cxiong@linkedin.com<mailto:cxiong@linkedin.com>>
Subject: Re: [naarad] Enable global configuration (#187)


In bin/naarad:

> @@ -154,6 +154,8 @@ def main():
>    variables_dict = {}
>    ts_start = None
>    ts_end = None
> +  ts_global_start = None
> +  ts_global_end = None


I am not sure if we need another set of ts_global_end and start variables. Can we reuse ts_start and ts_end instead?

Do you also want to implement getting ts_start and ts_end as CLI args?

—
Reply to this email directly or view it on GitHub<https://github.com/linkedin/naarad/pull/187/files#r11540744>.