Remove old "health_manager_next" code and references

Signed-off-by: Alex Suraci <asuraci@pivotallabs.com>
Remove access check that had no effect

[#67346972]

Signed-off-by: Abhijit Hiremagalur <abhi@pivotallabs.com>
Remove commented code
Don't persist broker/catalog changes when update fails

[Finishes #62008174]
Ensure client id is claimed before making UAA client

Also added ServiceDashboardClient.remove_claim_on_client instead of
directly accessing DB.

[Finishes #67885296]
Return correct error responses for invalid bind requests. [#65123304]

- invalid app_guid returns AppNotFound with 404
- invalid service_instance_guid returns ServiceInstanceNotFound with 404

previously they returned 500 errors.
Deleting a service broker deletes UAA clients

[Finishes #62008198]
Rename max_droplet_size to max_package_size

In preparation for surfacing the max app bits package size as a
configurable attribute in cf-release, rename
ccng.packages.max_droplet_size to ccng.packages.max_package_size to more
accurately reflect its purpose.

Also, since ccng.droplet.max_droplet_size is not used in the code,
remove its declaration from config.
Small cleanup to ServiceDashboardClientManager

Pre-instantiate the ServiceDashboardClientDiffer and make most accessors
private
Move bosh templates to CC that allow spliting single CC job to multiple ones.

* This is to reduce duplicates when we one to re-use configs in multiple jobs.

[#65336602]

Signed-off-by: Phan Le <ple@pivotallabs.com>
Add spec/README.md to describe role of specific test folders

To start, only documented spec/acceptance and
spec/acceptance/broker_api_compatibility, as these two folders have
caused confusion recently.
Add a job to create/update buildpacks

Refactored based on initial comments
Update config schema for the various options
CreateClientCommand does not save claim on client upon failure to create it in UAA

- rename some variables and methods for clarity
Allow v2 broker catalog to include free field on service plans. [#67865658]
Removed the code stink from the 'should not log passwords'.
deactivating/deleting services during catalog update now scoped to broker

- extract catalog sync into service_manager object
[finishes #68026188]
Refactored App validation policies to reduce complexity.

[finishes #68152780]

Signed-off-by: James Myers <jmyers@pivotallabs.com>
improved diego staging message
* renamed uri fields to be more descriptive
* removed unused staging message fields
* renamed admin_buildpack methods to just buildpack

Signed-off-by: David Varvel <dvarvel@pivotallabs.com>
Merge pull request #176 from fraenkel/removebuildpacks

Add a job to create/update buildpacks

Re-ran travis and verified locally
Merge pull request #150 from mheath/removepasswordlogging

Don't log message fields that may contain passwords.

Verified locally, merging