Fixed NPE on jar/war files without manifest
Allowing preparedPaths to be true even if there are errors.

This change means that if there are TONS of errors, the project won't be
reprocessed over and over and over again. A simple way to see where
this would be a problem is if you had many projects that included
each other in their buildpaths. Now remove one of the foundational
projects from your workspace -- actually delete the files, not
just delete the eclipse project. the Project class will get hung up
because it continues to process all Projects because none of them
are ever "Ok".
CachingUriResourceHandlerTest: cleanup after tests 2, 3 and 6

Signed-off-by: Ferry Huberts <ferry.huberts@pelagic.nl>
ProjectTest: cleanup after tests

Signed-off-by: Ferry Huberts <ferry.huberts@pelagic.nl>
ResourceTest: cleanup after tests

Signed-off-by: Ferry Huberts <ferry.huberts@pelagic.nl>
BaselineTest: cleanup after tests

Signed-off-by: Ferry Huberts <ferry.huberts@pelagic.nl>
WorkspaceRepositoryTest: cleanup after tests

Signed-off-by: Ferry Huberts <ferry.huberts@pelagic.nl>
ProjectLaunchImplTest: cleanup after tests

Signed-off-by: Ferry Huberts <ferry.huberts@pelagic.nl>
TestIndex: clean up after tests

Signed-off-by: Ferry Huberts <ferry.huberts@pelagic.nl>
Project: fix copy/paste bug, found by FindBugs

Project.java:2512, DLS_DEAD_LOCAL_STORE_SHADOWS_FIELD, Priority: High

DLS: Dead store to target rather than field with same name in
aQute.bnd.build.Project.getCommonJavac(boolean)

This instruction assigns a value to a local variable, but the value is
not read or used in any subsequent instruction. Often, this indicates
an error, because the value computed is never used. There is a field with
the same name as the local variable. Did you mean to assign to that
variable instead?

Signed-off-by: Ferry Huberts <ferry.huberts@pelagic.nl>
Fix invalid format string, found by Findbugs

CachingUriResourceHandle.java:196
VA_FORMAT_STRING_EXTRA_ARGUMENTS_PASSED, Priority: High

FS: Format-string method String.format(String, Object[]) called with
format string "Invalid SHA on remote resource" wants 0 arguments but is
given 1 in aQute.bnd.deployer.repository.CachingUriResourceHandle.request()

Builder.java:1633
VA_FORMAT_STRING_EXTRA_ARGUMENTS_PASSED, Priority: High

FS: Format-string method String.format(String, Object[]) called with
format string "${githead}, provide the SHA for the current git head" wants
0 arguments but is given 1 in aQute.bnd.osgi.Builder._githead(String[])

A format-string method with a variable number of arguments is called, but
more arguments are passed than are actually used by the format string.
This won't cause a runtime exception, but the code may be silently
omitting information that was intended to be included in the formatted
string.

Signed-off-by: Ferry Huberts <ferry.huberts@pelagic.nl>
Fix 2 'dead local store' bugs found by findbugs

Signed-off-by: Ferry Huberts <ferry.huberts@pelagic.nl>
Fix 2 'unrelated types' bugs found by findbugs

Signed-off-by: Ferry Huberts <ferry.huberts@pelagic.nl>
Fix 2 'unrelated types' bugs found by findbugs

Signed-off-by: Ferry Huberts <ferry.huberts@pelagic.nl>
R6 package for the annotations. The code uses
strings (and had 3 error before I got the string right, long
live Java). So the package is only in the test code
#477 The method's return type was interpreted as raw type
bnd diffing only looked at the raw type of a return. It now uses
the generic signature of the return type. This will now
give a diff on a change from Collection<String> to 
Collection<Integer>. Since it uses the string representation
of the signature, Due to lack of time, I use the binary
form of the signature. So messages might look awkward. On the 
TODO list ...
Extra tests
Replace \n,\r,\b,\f,\t 's in the output of the macro processor
with the their real control code. This allows macros to generate
newlines.
Merge pull request #458 from KnisterPeter/master

Fixed NPE on jar/war files without manifest
#457 Exception in annotation handling
Turned out that the elements map was set to the Collections.empty() if there were no elements in the original annotations. This created an error when we tried to set a new value. Now use null for elements and will create a map when needed.
close