I'm going to check this right way and add a test.



On Mon, Apr 21, 2014 at 7:36 PM, Julian Hyde <notifications@github.com>wrote:

> In src/main/mondrian/olap/fun/BuiltinFunTable.java:
>
> > +                "+",
> > +                "Adds two String.",
> > +                "iSSS")
> > +        {
> > +            public Calc compileCall(ResolvedFunCall call, ExpCompiler compiler)
> > +            {
> > +                final StringCalc calc0 = compiler.compileString(call.getArg(0));
> > +                final StringCalc calc1 = compiler.compileString(call.getArg(1));
> > +
> > +                return new AbstractStringCalc(call, new Calc[] {calc0, calc1}) {
> > +                    public String evaluateString(Evaluator evaluator) {
> > +                        final String s0 = calc0.evaluateString(evaluator);
> > +                        final String s1 = calc1.evaluateString(evaluator);
> > +
> > +                        if (s0 == null && s1 == null) {
> > +                            return null;
>
> "a string" + null returns "a string". did you check ssas?
>
> in standard SQL 'a string' || null returns null.
>
> it's worth a test.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/pentaho/mondrian/pull/277/files#r11819577>
> .
>



-- 
Aníbal Fernandes
Development Team

http://www.webdetails.pt