Merged r1590801 from tomcat/trunk:
Document JspAttribute.isDynamic() and correct wrong value of this flag for "omit" attribute of <jsp:attribute> action.

I think there were no observable consequences of this typo. The "dynamic" flag makes sense only for attributes of a CustomTag.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/tc7.0.x/trunk@1590844 13f79535-47bb-0310-9956-ffa450edef68
Merged r1590646 from tomcat/trunk:
Fix Javadoc warnings

git-svn-id: https://svn.apache.org/repos/asf/tomcat/tc7.0.x/trunk@1590845 13f79535-47bb-0310-9956-ffa450edef68
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=56334
Merged r1590842 from tomcat/trunk:
Additional tests and fixes
Includes the following:

1. Allow '\' in xmlns attributes of UninterpretedTag. A test added.

(Java escaping was missing. Xml-escaping is still missing. I think it is unlikely that anybody would use such values for xmlns attributes)

2. Fix interaction between Validator.ValidateVisitor.checkXmlAttributes(CustomTag ..) and getJspAttribute().

- EL expression was parsed twice in both methods. Now I am passing the already parsed EL.
- getJspAttribute() has EL validation code, so reduce duplication
- When calling getJspAttribute() you have to pass original attrs.getValue(i), not the textual value.

3. Fix Validator.ValidateVisitor.XmlEscapeNonELVisitor
- It was not EL-escaping its text. Tests added.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/tc7.0.x/trunk@1590848 13f79535-47bb-0310-9956-ffa450edef68