Sync FSX with FSFS:  Remerge (record-only unmerge + merge) r1555135 from
libsvn_fs_fs without conflicts.  This applies the EOL style fixes to the
rev_file.* files, which did not exist during the initial merge.

git-svn-id: https://svn.apache.org/repos/asf/subversion/trunk@1636612 13f79535-47bb-0310-9956-ffa450edef68
Remove unnecessary conditions from FSX code.

* cached_data.c
  (svn_fs_x__rep_chain_length): FSX respositories are always sharded.

* transaction.c
  (shards_spanned): Same.


git-svn-id: https://svn.apache.org/repos/asf/subversion/trunk@1636614 13f79535-47bb-0310-9956-ffa450edef68
Sync FSX with FSFS:  Merge assorted fixes and improvements from libsvn_fs_fs
and resolve the usual conflicts with FSX.  The merged revisions are:

r1605633 - remove obsolete race handling between 'hotcopy' and 'pack'
r1616613 - improve config file documentation
r1620930 - reintroduce SVN_FS_FS__USE_LOCK_MUTEX conditional flag
r1622946 - fix rev/pack file open retry after pack
r1623368 - factor out some common code into svn_fs_fs__packed_base_rev()
r1623381 - bump instance ID upon recover
r1623402 - don't use instance IDs as part of the cache keys
r1626246 - fix some compiler warnings
r1627949 - make sure to detect format upgrades before committing
r1628161 - add missing error tracing
r1628393, r1628415 - fix compiler warnings in index.c
r1632908 - fix error leak


git-svn-id: https://svn.apache.org/repos/asf/subversion/trunk@1636627 13f79535-47bb-0310-9956-ffa450edef68
* subversion/libsvn_fs_fs/fs.h
  (SVN_FS_FS__USE_LOCK_MUTEX): Remove outdated reference from docstring.
                               no functional change.

git-svn-id: https://svn.apache.org/repos/asf/subversion/trunk@1636629 13f79535-47bb-0310-9956-ffa450edef68
Sync FSX with FSFS:
Block (record-only) merge changes from libsvn_fs_fs that have limited
impact on FSX performance and affect code that is to be rewritten.

r1604414 - default to uncompressed revprops
r1624512 - custom shard size
r1634872 - set revprop pack size default to 4kB

git-svn-id: https://svn.apache.org/repos/asf/subversion/trunk@1636638 13f79535-47bb-0310-9956-ffa450edef68
Sync FSX with FSFS:
Record-only merge changes from libsvn_fs_fs that either have already
been replaced manually or don't apply to FSX at all.  Revisions:
r1605123, r1636478, r1636483 and r1636629.

git-svn-id: https://svn.apache.org/repos/asf/subversion/trunk@1636639 13f79535-47bb-0310-9956-ffa450edef68
Don't use APR_*_FMT marcros in localized strings.

* subversion/libsvn_fs_fs/index.c
  (stream_error_create): Format number as string before passing it into
                         a localizes error message.
  (packed_stream_read): Update caller.

* subversion/libsvn_fs_x/index.c
  (stream_error_create,
   packed_stream_read): Same as for FSFS.
  (read_uint32_from_proto_index,
   read_off_t_from_proto_index,
   read_p2l_sub_items_from_proto_index): Format numbers as string before
                                         passing them into localized error
                                         messages.

git-svn-id: https://svn.apache.org/repos/asf/subversion/trunk@1636644 13f79535-47bb-0310-9956-ffa450edef68
FIx release packages to work with OS X 10.10 (Yosemite)

* tools/dist/release.py: Bump libtool version to 2.4.3, versions prior to 2.4.3
    treat OS X 10.10 as 10.1 which then causes the linker to be told to ignore
    undefined symbols rather than resolve them.  This causes runtime crashes.


git-svn-id: https://svn.apache.org/repos/asf/subversion/trunk@1636714 13f79535-47bb-0310-9956-ffa450edef68
Minor consistency fix - even though the result returned by the previous
code was technically correct.

* subversion/libsvn_fs_util/fs-util.c
  (svn_fs__path_change_create_internal): Unused copyfrom revs should be
                                         initialized to -1 even if we
                                         correctly default to "copyfrom
                                         is unknown".


git-svn-id: https://svn.apache.org/repos/asf/subversion/trunk@1636733 13f79535-47bb-0310-9956-ffa450edef68
Provide a simple test for svn_fs_path_change2_create.

* subversion/tests/libsvn_fs/fs-test.c
  (test_path_change_create): The new test.
  (test_funcs): Register the new test.

git-svn-id: https://svn.apache.org/repos/asf/subversion/trunk@1636734 13f79535-47bb-0310-9956-ffa450edef68
Add a FS API test for svn_fs_node_created_path and svn_fs_node_created_rev.

* subversion/tests/libsvn_fs/fs-test.c
  (test_node_created_info): The new test.
  (test_funcs): Register the new test.


git-svn-id: https://svn.apache.org/repos/asf/subversion/trunk@1636749 13f79535-47bb-0310-9956-ffa450edef68
Add a simple test case for svn_fs_print_modules.

* subversion/tests/libsvn_fs/fs-test.c
  (test_print_modules): New test case.
  (test_funcs): Register the new test case.


git-svn-id: https://svn.apache.org/repos/asf/subversion/trunk@1636757 13f79535-47bb-0310-9956-ffa450edef68
Add a test for svn_fs_try_process_file_contents.

* subversion/tests/libsvn_fs/fs-test.c
  (process_file_contents_baton_t,
   process_file_contents): New processing callback & baton type.
  (test_zero_copy_processsing): New test.
  (test_funcs): Register the new test.


git-svn-id: https://svn.apache.org/repos/asf/subversion/trunk@1636873 13f79535-47bb-0310-9956-ffa450edef68
Docstring fix.  No functional change.

* subversion/include/svn_io.h
  (svn_stream_skip): Add missing "@since" statement.

git-svn-id: https://svn.apache.org/repos/asf/subversion/trunk@1636874 13f79535-47bb-0310-9956-ffa450edef68
* subversion/include/svn_fs.h
  (svn_fs_try_process_file_contents): Fix grammer and improve wording of
                                      the docstring. No functional change.

git-svn-id: https://svn.apache.org/repos/asf/subversion/trunk@1636877 13f79535-47bb-0310-9956-ffa450edef68
Fix help string formatting for svnadmin verify

* subversion/svnadmin/svnadmin.c
  (options_table): Add newline for metadata-only

Obvious fix.


git-svn-id: https://svn.apache.org/repos/asf/subversion/trunk@1637014 13f79535-47bb-0310-9956-ffa450edef68
Make FSFSv7 repositories always use consistent addressing mode, instead of
saving revision number from which logical addressing was enabled.

From the performance point of view there will be no big benefits to enable
log addressing for an existing repository, because the existing old part
of the repository will remain to be addressed physically. So those who
want to benefit from the performance improvements related to the log
addressing feature will be required to dump/load their repositories anyway.

On the other hand, consistent addressing allows us to omit some tricky code.

This also fixes problems with long living svn_fs_t instances during the hot
repository upgrade in background.

* subversion/libsvn_fs_fs/fs.h
  (PATH_TXNS_LA_DIR): Remove.
  (fs_fs_data_t): Replace MIN_LOG_ADDRESSING_REV member with simple
   USE_LOG_ADDRESSING flag.

* subversion/libsvn_fs_fs/fs.c
  (initialize_fs_struct): Initialize USE_LOG_ADDRESSING field instead of
   MIN_LOG_ADDRESSING_REV.

* subversion/libsvn_fs_fs/util.c
* subversion/libsvn_fs_fs/util.h
  (svn_fs_fs__use_log_addressing): Remove REV argument.

* subversion/libsvn_fs_fs/cached_data.c
  (dbg_log_access, use_block_read, svn_fs_fs__rev_get_root,
   svn_fs_fs__check_rep, svn_fs_fs__get_changes): Adapt calls to
   svn_fs_fs__use_log_addressing().

* subversion/libsvn_fs_fs/dump-index.c
  (svn_fs_fs__dump_index): Adapt calls to svn_fs_fs__use_log_addressing().

* subversion/libsvn_fs_fs/fs_fs.c
  (read_format): Replace MIN_LOG_ADDRESSING_REV output parameter with
   USE_LOG_ADDRESSING. Do not parse revision number if repository uses
   logical addressing mode.
  (svn_fs_fs__write_format): Simple write "addressing physical" or
   "addressing logical" to format file depending repository addressing mode.
  (svn_fs_fs__read_format_file): Adapt calls to read_format() function.
  (upgrade_body): Replace local variable  MIN_LOG_ADDRESSING_REV with
   USE_LOG_ADDRESSING flag. Adapt calls to read_format() and remove
   code that renames transaction folder during upgrade.
  (write_revision_zero): Adapt calls to svn_fs_fs__use_log_addressing().
  (svn_fs_fs__create_file_tree): Replace MIN_LOG_ADDRESSING_REV argument with
   USE_LOG_ADDRESSING flag and use it for FFD->USE_LOG_ADDRESSING
   initialization.
  (svn_fs_fs__create): Pass TRUE for USE_LOG_ADDRESSING parameter in call to
   svn_fs_fs__create_file_tree().

* subversion/libsvn_fs_fs/fs_fs.h
  (svn_fs_fs__create_file_tree): Update function declaration and docstring.

* subversion/libsvn_fs_fs/hotcopy.c
  (hotcopy_create_empty_dest): Adapt call to svn_fs_fs__create_file_tree().

* subversion/libsvn_fs_fs/load-index.c
* subversion/libsvn_fs_fs/index.c
  (svn_fs_fs__item_offset, svn_fs_fs__load_index): Adapt calls
   to svn_fs_fs__use_log_addressing().

* subversion/libsvn_fs_fs/pack.c
  (svn_fs_fs__order_dir_entries, pack_rev_shard): Adapt calls
   to svn_fs_fs__use_log_addressing().

* subversion/libsvn_fs_fs/stats.c
  (parse_representation, read_noderev, read_revisions): Adapt calls
   to svn_fs_fs__use_log_addressing().

* subversion/libsvn_fs_fs/transaction.c
  (auto_truncate_proto_rev, store_p2l_index_entry, allocate_item_index,
   write_final_rev): Adapt calls to svn_fs_fs__use_log_addressing().
  (store_l2p_index_entry): Remove FINAL_REVISION argument. Adapt calls
   to svn_fs_fs__use_log_addressing().
  (compare_sort_p2l_entry, using_log_addressing, upgrade_transaction):
   Remove.
  (commit_body): Remove call to upgrade_transaction().

* subversion/libsvn_fs_fs/verify.c
  (svn_fs_fs__verify): Adapt calls to svn_fs_fs__use_log_addressing().

* subversion/tests/libsvn_fs/fs-test.c
  (upgrade_while_committing): Expect that begin_txn and commit doesn't fail
   after upgrade to fsfs7.


git-svn-id: https://svn.apache.org/repos/asf/subversion/trunk@1637184 13f79535-47bb-0310-9956-ffa450edef68
Follow-up to r1637184: Remove some unused code.

* subversion/libsvn_fs_fs/fs_fs.c
  (upgrade_body): Remove unused TXNS_DIR local variable and it's
   initialization.

* subversion/libsvn_fs_fs/transaction.c
  (is_noderev_file, fnv1a_checksum_on_file_range): Remove unused functions.

* subversion/libsvn_fs_fs/util.c
  (svn_fs_fs__path_txns_dir): Remove unused variable.


git-svn-id: https://svn.apache.org/repos/asf/subversion/trunk@1637186 13f79535-47bb-0310-9956-ffa450edef68
Follow-up to r1621277: Adjust load-index help text

* subversion/svnfsfs/svnfsfs.c
  (cmd_table): Adjust help text to reflect load-index reading from
               console, and the mirror command being dump-index.

Obvious fix.


git-svn-id: https://svn.apache.org/repos/asf/subversion/trunk@1637205 13f79535-47bb-0310-9956-ffa450edef68
Apply equivalent change to r1522518 to svn-bench help output

* subversion/svn/help-cmd.c
  (svn_cl__help): No not show the version number in help output as
    --version is provided. Name it Subversion benchmarking tool.

Approved by: stsp



git-svn-id: https://svn.apache.org/repos/asf/subversion/trunk@1637247 13f79535-47bb-0310-9956-ffa450edef68