EAGLESIX-3157: matcher: fix jshint issues

Fix JSHint issues with new pipeline matcher code ported from 2.6.5 code.
Part of an effort to cleanup various JSHint issues in one fell swoop so that we can keep things a bit cleaner going forward.

I wanted to intentionally make it exact so that any changes that make it even more complex would need to be done with extra care.