Mwprochaska rename and mstest

•	Move the test project from nUnit-based to MSTest-based (It allowed me to reuse a bunch of code from other projects).
•	Widespread rename, “marlin” is now only a solution name, it does not exist in any namespace or class.  (I left it as the name of test tables as well)
•	Enable code analysis
•	Increase code coverage to ~69% all-up
•	Standardize the validation of DTOs.  (DTOs are now read-only, null and empty are uniformly treated)
•	Added standard Apache 2.0 file headers

Maxim,
 
I had not considered it; I will evaluate it formally in the morning; likely yes.  I do not see a deficit of ability nor knowledge in the original work; I see a lack of discipline in scope and responsibility -- nothing more.  We've changed the scope, it is up to us to change the acumen.
 
(I was more focused on what I absolutely did not want to publicly support; we discussed it yesterday, an unformatted text file with a plain-text password).  Not wrong, but not something I want to bite on.
 
~Michael
 
Ripping out the Marlin ascii art gave me pause (in all seriousness, you should ask him if he wants it preserved in some fashion).  I left the Marlin.sln in deference.  (I expect you to manage this).  IMO we are transitioning from PoC to supportable API.  This was my first touch, I was trying to be minimalistic; I am open to guidance.
 
The API needs work, it does not have to happen now -- it should happen before we abandon "pre-release"
My 2 cents.
 
Date: Thu, 24 Jul 2014 18:20:50 -0700
From: notifications@github.com
To: hbase-sdk-for-net@noreply.github.com
CC: mwprochaska@outlook.com
Subject: Re: [hbase-sdk-for-net] Mwprochaska rename and mstest (#1)

In Microsoft.HBase.Client/WebRequester.cs:

> +// See the Apache Version 2.0 License for specific language governing
> +// permissions and limitations under the License.
> +
> +namespace Microsoft.HBase.Client
> +{
> +    using System;
> +    using System.Diagnostics.CodeAnalysis;
> +    using System.IO;
> +    using System.Net;
> +    using System.Threading.Tasks;
> +    using Microsoft.HBase.Client.Internal;
> +
> +    /// <summary>
> +    /// 
> +    /// </summary>
> +    public sealed class WebRequester

Can we make this class internal?


—
Reply to this email directly or view it on GitHub.