Test Fixes - PGWiki - paths
Test Fixes - PGWiki - macros
Test Fixes - PGWiki - tests
Test Fixes - SecurityUsecase - paths
After SF it is needed to create a protected field so the class is fully coverage
LPS-49277 Add a ToolbarItem class to serve the same purpose as MenuItem but for toolbars.
LPS-49277 Rename methods in MenuItem to resemble those in ToolbarItem. The rationale behind this change is that even if ToolbarItem and MenuItem are different things, they share many common characteristics.Thus, if we name those common characteristics the same, we can then create interfaces to treat them equally and remove duplication. I won't create those interfaces until they are needed, but this step will make it easier when that time comes.
LPS-49277 Create a tag lib to render ToolbarItem instances
LPS-49277 Add a new method to DLViewFileVersionDisplayContext to delegate calculation of toolbar to the DC. Implement that functionality for the default DC.
LPS-49277 Fix _getRenderURL() method in DefaultDLViewFileVersionDisplayContext
LPS-49277 Extract interfaces for MenuItems and ToolbarItems with common methods. These will be used in the next commit to remove duplication and simplify code.
LPS-49277 Simplify and remove duplication in DefaultDLViewFileVersionDisplayContext
LPS-49277 Since we are sharing object structures we also want to share its instance ids. Otherwise, reuse is not possible.
LPS-49277 Apply the MenuItem's logic to ToolbarItem's in GoogleDocsDLViewFileVersionDisplayContext
LPS-49277 Fix a NPE
LPS-49277 SF
LPS-49277 SF
LPS-49277 Go  with set* order
LPS-49277 Use newly added method
LPS-49277 Sorry, undoing my earlier change since one uses the other