I think that's fine. You're right you're not using the target because the
suggestion contains it. I think it'd be slightly cleaner if the Team model
were the target, but I don't think it matters.


On Fri, Feb 21, 2014 at 10:17 PM, Eugene Fang <notifications@github.com>wrote:

> In models/suggestion.py:
>
> > @@ -21,7 +21,7 @@ class Suggestion(ndb.Model):
> >      reviewer = ndb.KeyProperty(kind=Account)
> >      author = ndb.KeyProperty(kind=Account, required=True)
> >      contents_json = ndb.StringProperty(indexed=False)  # a json blob
> > -    target_key = ndb.StringProperty(required=True)  # "2012cmp"
> > +    target_key = ndb.StringProperty()  # "2012cmp"
>
> Thoughts on how to deal with this, or is this okay?
>
> --
> Reply to this email directly or view it on GitHub<https://github.com/gregmarra/the-blue-alliance/pull/900/files#r9970225>
> .
>