On 02/01/14 18:55, Edward Welbourne wrote:
>
> In libpromises/evalfunction.c:
>
> > +    {
> > +        if (lstat(rp->val.item, &statbuf) == -1)
> > +        {
> > +            Log(LOG_LEVEL_VERBOSE, "Function makerule, one of the source files was not readable");
> > +            return FnFailure();
> > +        }
> > +        else
> > +        {
> > +            if (statbuf.st_mtime > target_time)
> > +            {
> > +                result = true;
> > +            }
> > +        }
> > +    }
> > +
> > +    if (result)
>
> Could be rewritten as |
> return result ? FnReturnContext(true) : FnFailure();
> |, FWIW.
>
> —
> Reply to this email directly or view it on GitHub 
> <https://github.com/cfengine/core/pull/1232/files#r8618051>.
>

Sure, why not

-- 
Founder and CTO at CFEngine
Author of In Search of Certainty: The Science of our Information 
Infrastructure <http://markburgess.org/certainty.html>