Fixes #4528: Move r31417 to v1.8 branch (coll/ml: fix issues identified by)
Fixes #4617: Move r31737, r31822 to v1.8 branch (basesmuma: clean up the setup)
Fixes #4618: Move r31743 to v1.8 branch (coll/ml: fix leaks and close)
Fixes #4620: Move r31745, r31760 to v1.8 branch (sbgp/base: fix memory leaks)
Fixes #4680: Move r31893 to v1.8 branch (bcol/basesmuma: fix remaining memory leaks)
Fixes #4778: coll/ml rollup

---svn-pre-commit-ignore-below---

r31104 [[BR]]
Remove unnecessary \n's in ML_VERBOSE and ML_ERROR.

Also fixed spelling: IS_NOT_RECHABLE -> IS_NOT_REACHABLE.

Also mark a few places where opal_show_help() should have been used;
Manju will take care of these.

r31264 [[BR]]
coll/ml: fix leaks

Thanks to ggouaillardet for finding and fixing these issues.

Closes #4460

cmr=v1.8.1:reviewer=manjugv

r31279 [[BR]]
coll/ml : Replace longer error message with opal_show_help; thanks Jeff for identifying those

r31417 [[BR]]
coll/ml: fix issues identified by the clang static analyser and fix
a segmentation fault in the reduce cleanup

Some of the changes address false warnings produced by scan-build. I
added asserts and changed some malloc calls to calloc to silence these
warnings.

The was one issue in cleanup for reduce since the component_functions
member is changed by the allreduce call. There may be other issues
with how this code works but releasing the allocated
component_functions after setting up the static functions addresses
the primary issue (SIGSEGV).

cmr=v1.8.1:reviewer=manjugv

r31737 [[BR]]
basesmuma: clean up the setup code and ensure mapped files are unmapped

We were leaking file descriptors when coll/ml was in use. It turn out
this was because basesmuma was failing to unmap files it had previously
mapped. This commit cleans up the setup code to ensure that we only
attempt to map the control files once per module and then ensures the
files are unmapped when the module is released.

cmr=v1.8.2:reviewer=manjugv

r31743 [[BR]]
coll/ml: fix leaks and close all the framework opened

It is essential to call mca_base_framework_close for every framework
that is opened. coll/ml was not doing this so neither bcol nor sbgp
were getting cleaned up. This commit fixes this omission.

Also fixed a leak caused by calling OBJ_DESTRUCT for something created
with OBJ_NEW. With these changes coll/ml appears to be valgrind clean.

cmr=v1.8.2:reviewer=manjugv

r31745 [[BR]]
sbgp/base: fix memory leaks

This commit fixes memory leaks discovered in the sbgp setup code. We
were leaking an opal_argv as well as some list items. I took the
opportunity to clean up the code a little which includes making use of
the opal_argv_free function.

cmr=v1.8.2:reviewer=manjugv

r31760 [[BR]]
Looks like someone missed a '|' in this comparison, so correct it here



r31822 [[BR]]
bcol/basesmuma: fix leak in basesmuma code

Basesmuma was vallocing space for control data then mmapping over that
data. Nothing in the code suggests any need for mmapping a specific
address so I did the following to remove the leak:

 - Removed the valloc of the buffer space

 - ftruncate the mmaped file to ensure there is sufficient memory to
   allocate space for the control data.

Ideally this code should be using opal/shmem but that is a larger
change. Keeping it simple for now.

cmr=v1.8.2:reviewer=manjugv

r31893 [[BR]]
bcol/basesmuma: fix remaining memory leaks in basesmuma

We were still leaking 1) file descriptors for data files, and 2) some
control files. I fixed both of these leaks and everything is looking
good. This should fix the bug where we are running out of file
descriptors when running the loop_spawn test. I also too the
opportunity to refactor the code a bit to make the mapping/unmapping
simpler. This should help avoid these sorts of issues in the future.

Depends on #4678

cmr=v1.8.2:reviewer=manjugv

r32178 [[BR]]
coll/ml: temporarily disable binding check