add logic tests