Use the more common os_ names for novaclient

Users are quite accustomed to using these names, so we'll use
them. Also we may eventually want to monitor more than just
Nova.

The old parameters are not kept and will not be utilized anymore.

Change-Id: I17b6cb765ce73478204a66ae7fa79f4fb0cda14c
Refactor nagios3 element to refresh more often

Previously the element would only refresh from Nova when the
Heat configuration was changed. But we want it to refresh
whenever nova changes.

Note that we won't actually remove hosts that go away.

Change-Id: Ic8af7f30ccc0cc2c64643081a6e300a354d8ad35
Allow users to use swift out of the box

When you assign a user to project in Horizon, this change allows
that user to use swift without further action.

Notes:

- This change is related to https://review.openstack.org/#/c/92388/
  in tripleo-incubator but can merge independently.
- Once this change merges, a logical follow up is to remove
  the creation of the swiftoperator role in tripleo-incubator
- However, in *this* change, we setup tempest to allow a
  subsequent removal of swiftoperator (the motivation is to
  reduce the number of roles for admins to manage)

Change-Id: Ib45e915eed923f7b8360593eb732e09b9683e77f
Enable additional ml2_conf.ini configuration

This change allows mechanism_drivers and vni_ranges to be
configurable.  Also, enables config passthrough support for
ml2_conf.ini.

Change-Id: Ifd8e5c52b89ae5eeab1a1399fe9dd77bf0c67ec6
Passthrough-enable keystone.conf.

This permits passthrough settings to be applied to keystone.conf using
'keystone' as the key in the config.

Change-Id: If43f5786bdb56299d68d0d068177a45b1ff30286
blueprint: passthrough-config
Fix permissions on ironic virtual pm key

Private ssh keys should have permissions of 600. We also should
explicitly make this the case rather than relying on o-a-c to preserve
permissions from cloned code. Additionally, the ironic process needs to
be able to read this key.

Change-Id: I0f4ce9f0b641c8634a927f79a803159a8884aaf2
Update icinga install script to enable icmp checks

This patchset updates the icinga-core installation script to
setup the check_icmp icinga plugin as setuid.

For some reason the package doesn't seem to do this so we need to
do that here.

I've also tidied up the set -eux and set -pipefail at the top of
the script.

Change-Id: I35f5e3ffcfcab5d93a7bf902ba12fc7d0afea691
add some missing “set -ue” declarations

Since 79ab95b16e78d563c473b5acada62cb3e22d4eb1 dib-lint ensure
every element shell scripts have “set -e” activated.

Even if dib-lint doesn't test it yet, the set -u is already widely
used.

As pointed out by Jiri Stransky, elements/tripleo-cd/configs/* files
are sourced by deploy-testenv. There is no reason to enable “set -ue”
manually. The patch just disable the dib-lint “sete” check on these files.

Change-Id: I118c8c80ec50b265c22577b075d15f56389b7a47
Issue in openstack-client that stops nova being in a common-venv

Install the openstack client libraries with 'pip install .' and
not python setup.py develop. The reason for this is that
python setup.py develop had the side effect of changing the
python path inside the virtualenv causing the problems whereas
pip install . doesn't.

I also want to delete the /opt/stack/python-client git directories
later.

Change-Id: Idc68e85c68f1c423f083e656d65d1654688dc84b
Glance: Enable passthrough configuration

This change enables config passthrough support for the following
Glance config files:

* glance-api.conf
* glance-registry.conf
* glance-cache.conf
* glance-scrubber.conf

Glance passthrough parameters can be injected into devtest by setting the
environment variable OVERCLOUD_EXTRA_CONFIG to a JSON structure such as:

{
    "glance-api": {
        "config": [
            {
                "section": "default",
                "values": [
                    {
                        "option": "qpid_port",
                        "value": "5672"
                    }
                ]
            }
        ]
    },
    "glance-registry": {
        "config": [
            {
                "section": "default",
                "values": [
                    {
                        "option": "limit_param_default",
                        "value": "100"
                    }
                ]
            }
        ]
    }
}

Change-Id: If0269b1935a10887ee3262e056d67a407131793a
blueprint: passthrough-config
Enable neutron.conf passthrough configuration

This change enables config passthrough support for neutron.conf.

blueprint: passthrough-config

Change-Id: I4b853d2617f6992de7c40b6b01257ab9abac06e7
Ceilometer Config element for custom pipeline

-These elements are for overwriting of default pipeline.yaml
 defined in ceilometer element install.d

There should a be config element taking json configuration,
though that is non-trivial problem that will likely go
in a follow up patch.

Change-Id: Ib0035f5a4359885a9a30c98fdecb86b940e9cb6a
Prevent tftp sysv init script from firing.

This is an equivalent fix to I01f34c6869b60432cff115e46246cd526ec12a62
for ironic; it disables any SysV startup script from launching
tftpd before xinetd can get a look-in.

Change-Id: I263aa756f80f7cbcbf5ca5ef5226136e9eab7ba1
Installing ssl-cert package as apache element requires it

The apache element fails because make-ssl-cert is required
but never installed.  This was never tested and yet has
been merged.  This is a CI/testing failure that should be
noted.

Change-Id: Iec001c20332efd61907f65744c2be1d98bf96a37
Closes-Bug: #1318761
Ironic: set my_ip equal to local-ipv4 (if present)

Ironic (like Nova) uses my_ip as a default value for other settings.

One of those settings is the tftp_server address. By setting
the default TFTP address in this manner we avoid the need
to configure an explicit tftp_server unless a non-default
value is needed.

For me this simple fix resolved TFTP failures I recieved when
trying to use Ironic to provision real baremetal.

Change-Id: I744c3a91e5967bab7da9c73cdc8821851e8f7d4b
Partial-bug: #1318039
indent using 4 spaces (2/3)

As advised in I072cf8bf6748d0c910fecffdf2282bcc4656d038, code should
use 4 spaces for indentation.
This commit enforces the use of 4 spaces indentation.
In order to simplify the review process, this patch only cover the
following elements:
 - nagios3
 - network-utils
 - neutron-openvswitch
 - nova-api
 - nova-baremetal
 - nova-compute
 - nova-kvm
 - openstack-client
 - openstack-db
 - openstack-ssl

Change-Id: I489746d384c0c2c5a4f2b12444606e3bf8e3ce11
Allow multiple binds per service in haproxy

The binds parameter in HAProxy can be repeated multiple times to bind to
multiple interfaces/ports. Creating a section called net_binds which
contains a list of optional IP and port parameters to set these.

Change-Id: Iec9fe803786738f3026cf8892c70b76d8fce4305
Add swiftclient library to swift

The swift-dispersion-populate/report tools in swift require
keystone authentication. In order to do this they need to import
the function "get_auth" from swiftclient. Therefore, swiftclient
is a requirement for running these tools and needs to be installed
because, similar to keystoneclient, it is not included in swift's
requirements.txt.

Change-Id: I9d486f8f484e98267caf24720faa49087582b690
Explicitly add the parted package.

Debian installs won't necessarily include parted by default.

Add the package to ironic-conductor.

Change-Id: I37ccbd3d66809ea387421f5b9b09572d4f366eb6
Standardise manifest creation and retrieval

Bring in line with the manifest standardisation in review
I37eff5a13a14564e1adc33eb4f0144d571267617

This:
    * Removes the pip-manifest cleanup script and corresponding
      README documentation
    * Adds a dependency on the manifests element
    * Uses the manifests element for manifest location and copy to
      build area
    * Standardises the manifest naming

Change-Id: I8ab0796a8e19419bf40c1ebc94a7eb04e3ba9180