Merge pull request #207 from lfxgroove/crash-on-shutdown-real

[Core] Fix crash on shutdown related to unloading SD2 library
Fixing bug with Warrior Execute

Warrior execute is actually working but not notifying the
client as it should. Once the execute is missed/dodged/parried
on default spellId's sent by the client, the spell miss message
isn't meaningfull for the client. In fact, it only reacts on
spell 20647 to display the result (damage or miss result).

Secondary, fixing the spell 20647 to avoid that it can actually miss
while the prior spell passed succesfully. This is asumption since the
DBC are reporting that the EquipItemID is -1 for the spell 20647
(making MeleeHitResult calculation false).

Signed-off-by: Talendrys <cedric_lesi@hotmail.com>
Workaround for the wow-error client raised once a player on transport
is leaving a map.
[Duel] Range is too small - Minor update

This range is aligned on what we can see on official Vanilla servers.
It allows easier kitting from ranged class.
Bug: Mighty Rage Potion and Elixir of giants

These effects are now stackable. Fixing bug #243.
Icons overload general review and code cleaning (refactoring)

This patch is fixing some icons overload. I've also performed a code
refactoring that all check always follows the same structure based on
embedded switches (always 2) for each kind of spell family. It helps a lot
to keep consistency while having to revert a check (for instance, checking
overloading between spells having different family must be performed twice,
once per case).

Although there are many Icons overload fixed, icons overload may still
exist in the game.

Also please note that I've not only fixed the reported overload but
a complete set of overload (by fixing directly on the SpellIconID where
it was possible - checking in the DBC).

The list of fixed overload:

https://www.getmangos.eu/issue.php?issueid=243
https://www.getmangos.eu/issue.php?issueid=244
https://www.getmangos.eu/issue.php?issueid=245
https://www.getmangos.eu/issue.php?issueid=246
https://www.getmangos.eu/issue.php?issueid=247
https://www.getmangos.eu/issue.php?issueid=248
https://www.getmangos.eu/issue.php?issueid=249
https://www.getmangos.eu/issue.php?issueid=250
https://www.getmangos.eu/issue.php?issueid=251
https://www.getmangos.eu/issue.php?issueid=252
https://www.getmangos.eu/issue.php?issueid=253
https://www.getmangos.eu/issue.php?issueid=254
https://www.getmangos.eu/issue.php?issueid=255
https://www.getmangos.eu/issue.php?issueid=256
https://www.getmangos.eu/issue.php?issueid=257
https://www.getmangos.eu/issue.php?issueid=258
https://www.getmangos.eu/issue.php?issueid=259
https://www.getmangos.eu/issue.php?issueid=260
https://www.getmangos.eu/issue.php?issueid=261
https://www.getmangos.eu/issue.php?issueid=262
https://www.getmangos.eu/issue.php?issueid=263
https://www.getmangos.eu/issue.php?issueid=264
https://www.getmangos.eu/issue.php?issueid=265
https://www.getmangos.eu/issue.php?issueid=266
Adding support of one-hand/two-hand custom spell bonus coeff in the core.

It appears that, at least one, spell in the game is using different spell bonus coeff
for direct damage based on the equiped weapon type (1H - 2H). Therefore, I've prepared
 a DB update and a code update to take care of this behavior. Seal of Righteousness is
 provided as a sample of this behavior.
Revert "Adding support of one-hand/two-hand custom spell bonus coeff in the core."

This reverts commit e72f29960d543b0d082fc9f0b6ec6b4c4fa1f138.
Merge pull request #222 from Warkdev/Rel20_Talendrys

[Core] Fix issues 240-266