Recommend the right call instead of datetime.now()

Closes-Bug: #1258166
Change-Id: I92b94dbcd0405d8f2bb818ad1c44c4f4934c8bec
Workers verification for WSGI service

When we start the nova-api service, the *_workers (metadata_workers,
ec2_workers, osapi_compute_workers) value are not verified if the value
is negative. If the user passes a negative value accidentally, and
InvalidInput exception will be threw.

Change-Id: I8337d672cb119efe700aa6be420fdac9864c1577
Closes-bug: #1269997
vmwareapi:remove unused variables in volumeops

Variables instance_name were not used in two methods,
Let us remove them.

Change-Id: Ib617aa82651923ebb2824edf5ff5008f61898bfb
Use objects internally in DriverBlockDevice class

This patch makes DriverBlockDevice use objects to do the database
updates. The object will be kept as a private object attribute and the
only change in the external API of the DriverBlockDevice objects is an
addition of the save() method.

This patch also removes the block_device_mapping_update method from the
VirtAPI class as that functionality can now be handled by
DriverBlockDeviceDict class (using BlockDeviceMapping objects
internally).

Also cleans up tests and simplifies some code in the libvirt driver that was
relying on virtapi to do the db updates.

Related to blueprint: icehouse-objects
Related to blueprint: clean-up-legacy-block-device-mapping

Change-Id: Ibafd1a05fb1050349ad12c0cafac77f64a8e96d8
Add 'icehouse-compat' to [upgrade_levels] compute=

Add support for the 'icehouse-compat' value for the compute
configuration option in the [upgrade_levels] configuration option group.
This option is set during a live upgrade from havana to icehouse to
ensure that compute messages are sent that both havana and icehouse
understand.

This is added to stable/havana in this change id:
If09bd38c9d8c3beb5b95107c497699dec47aa3ef

DocImpact

Change-Id: Ic6656457afced20bff2f23c03493e72a96a00fb9
Allow deleting instances while uuid lock is held

Avoid issues where locked up operations on the instance prevent it
from being deleted by the user. Reasons for the lock up are a separate
issue and will be handled elsewhere, but terminating the instance
should not affect any tasks anyway. Any modification should already
gracefully handle the instance going away.

For more discussion about the issue see:
http://lists.openstack.org/pipermail/openstack-dev/2013-October/017454.html

This patch was merged once before and had to be reverted in
6b7304d8d38c0f04643bdcd031d682c688c91b28.  It was causing an extremely
large number of errors in gate jobs.  I believe that the case being hit
should be expected with this patch in place, and that it's actually OK.
We expect that the rest of the code will handle this case gracefully.
Simply remove this error message from the code.

Change-Id: I83deae464518fef5abe8fc00bfd0a186de01527b
Partial-Bug: #1248563
Co-authored-by: Russell Bryant <rbryant@redhat.com>
Remove extra space in log message

Change-Id: I52993874dad7d89edcdaba36e1227c26cc3e8f43
Remove XML support from migrations pci multiple_create v3 API plugins

Remove XML support from the following v3 compute API plugins:

 - migrations
 - multiple_create
 - pci

Part of blueprint remove-v3-xml-api

DocImpact

Change-Id: If7dfda52eea63a39fae0e546cfeaf4b1d814b7b9
Deal with old versions of libguestfs

Commit 02abbef960b12deaa7a911788dbc56f3a0bd555a added the use of the
close_on_exit parameter.  This is supported by libguestfs 1.20 and up.
Catch the exeption raised when this parameter isn't supported and retry
without it.

Change-Id: Ic47c1cb997ece3710f8c4465733148fcfa94068d
Closes-Bug: #1271562
Related-Bug: #1261475
Merge "Remove extra space in log message"
Merge "Recommend the right call instead of datetime.now()"
Merge "Remove XML support from migrations pci multiple_create v3 API plugins"
Merge "Workers verification for WSGI service"
Merge "Add 'icehouse-compat' to [upgrade_levels] compute="
Merge "Use objects internally in DriverBlockDevice class"
Merge "Deal with old versions of libguestfs"
Merge "vmwareapi:remove unused variables in volumeops"
Merge "Allow deleting instances while uuid lock is held"