I agree. That is why in Dsw_psi.h I only defined those functions that could
be different. Only things that were defined locally in D_psi.c are the ones
duplicated in Dsw_psi.c. I can avoid this also by adding new functions to
D_psi.h.


On Fri, Mar 14, 2014 at 9:15 PM, Carsten Urbach <notifications@github.com>wrote:

> In operator/Dsw_psi.c:
>
> > @@ -0,0 +1,1431 @@
> > +/***********************************************************************
>
> @amabdelrehim <https://github.com/amabdelrehim> I think it is a very bad
> idea to double all the code here that is already in D_psi.c. There should
> be a solution similar to what we do in the even/odd case, where we use
> macros to build these operators. Here we could just re-use the functions
> local_H for instance, etc. But it must not be doubled!
>
> --
> Reply to this email directly or view it on GitHub<https://github.com/etmc/tmLQCD/pull/279/files#r10622643>
> .
>