basic edit done