Yes, I was thinking in those lines to measure the errors..


On Thu, Mar 27, 2014 at 10:52 AM, Henry Hsu <notifications@github.com>wrote:

> In server/server.js:
>
> > @@ -130,21 +130,11 @@ Server.prototype.message = function(client, data) {
> >    if (resource && resource.authorize(message, client, data)) {
> >      if(!this.subs[resource.name]) {
> >        logging.info('#redis - subscribe', resource.name);
> > -      this.subscriber.subscribe(resource.name, function(err) {
> > -        if(!err) {
> > -          logging.info('#redis - successfully subscribed', resource.name);
> > -          self.subs[resource.name] = true;
> > -          resource.handleMessage(client, message);
> > -          self.emit(message.op, client, message);
> > -        } else {
> > -          logging.error('#redis - could not subscribe to redis resource', resource.name);
> > -        }
> > -      });
> > -    } else {
> > -      logging.info('#redis - already subscribed', resource.name);
> > -      resource.handleMessage(client, message);
> > -      self.emit(message.op, client, message);
> > +      this.subscriber.subscribe(resource.name);
>
> Perhaps we can maintain some of this logging so we can know if subscribes
> succeed or not.
>
> this.subscriber.subscribe(resource.name, function(err) {
>   if(!err) {
>     logging.info('#redis - subscribe callback', resource.name);
>   } else {
>     logging.error('#redis - could not subscribe to redis resource', resource.name);
>   }});
>
> --
> Reply to this email directly or view it on GitHub<https://github.com/zendesk/radar/pull/69/files#r11035312>
> .
>