Fixed error when unbinding items, removed /* */
Corrected some local 'mapindex' variables shadowing the global one

Signed-off-by: Haru <haru@dotalux.com>
HPM Hooks Update

Signed-off-by: HerculesWSAPI <Hercules@efficiently.awesome>
modified second "infinity loop !" error so that its different from the first

and thus doesn't cause confusion (and it wasn't loop-related anyway).

Signed-off-by: shennetsind <ind@henn.et>
Item database bug fixes.
#5608: Proper groups for Lotto Boxes
#5625: Missing function for Dungeon Teleport Scroll II
#5612: Missing skills
Fix core bug issue 7435: When the Storage is open
ensuring script_state is clear (as ers reuses memory).

Signed-off-by: shennetsind <ind@henn.et>
Follow up b7171479

Fixed couple intif.c interface members being called outside the interface

Signed-off-by: shennetsind <ind@henn.et>
Corrected a minor error (wrong constant name) in the bard quest.

Signed-off-by: Haru <haru@dotalux.com>
Replaced pc->get_group_level with a macro (pc_get_group_level)

Because 2 jumps to get a single value is just awful.

Signed-off-by: shennetsind <ind@henn.et>
Replaced pc->pc_has_permission/can_give_items/can_give_bound_items with equivalent macros

Because 2/3 jumps to perform such a operation is just awful

Signed-off-by: shennetsind <ind@henn.et>
Introducing HPM Support for custom battle confs

Special Thanks to Mhalicot.

Signed-off-by: shennetsind <ind@henn.et>
Added Apple Xcode project files

Signed-off-by: Haru <haru@dotalux.com>
Changed plugin extension from .so to .dylib on OS X

- No functional changes. That's just the correct OS X file extension for
  dynamic libs.

Signed-off-by: Haru <haru@dotalux.com>
Nullpo cleanup

- Removed unused, nonportable nullpo checks with formatted message
  (related: eAthena r15245)
- Converted nullpo_chk to a macro, to make it easier on the llvm static
  analyzer.
- Added more details to the nullpo_info reports (related: eAthena
  r15246)
- Ensured that the nullpo check macros evaluate their pointer argument
  once and only once, so that it's safe to use with expressions that
  assign values or have side-effects.

Signed-off-by: Haru <haru@dotalux.com>
Added support for non-aborting assertions

- Added Assert_ret, Assert_retv, Assert_retb, Assert_retr, working
  similarly to the corresponding nullpo_ functions.
- Moved Assert-related macros to nullpo.h, since they share some
  functions.

Signed-off-by: Haru <haru@dotalux.com>
Fixed several compiler warnings

- Warnings detected thanks to Xcode's compiler settings (more strict by
  default) and clang, warnings mostly but not only related to data sizes
  on 64 bit systems, that were silenced until now by very lax compiler
  settings.
- This also decreases by a great deal the amount of warnings produced by
  MSVC in x64 mode (for the adventurous ones who tried that)
- Also fixed (or silenced in case of false positives) the potential
  issues pointed out by the (awesome) clang static analyzer.
- Patch co-produced with Ind, I'm merging and committing in his place!

Signed-off-by: Haru <haru@dotalux.com>
Increased warnings level in the unix build scripts

- They are now on par with the Xcode project (and similar to the MSVC
  ones) - this will make it easier to notice issues before committing in
  future.
- If this causes, on your system, warnings that we didn't detect, please
  let us know!

Signed-off-by: Haru <haru@dotalux.com>
Fixed some additional linux warnings

- Fixed some warnings we had missed.
- Improved -W cflag detection routines.
- Only use -Wshadow if it's actually useful.

Signed-off-by: Haru <haru@dotalux.com>
Merge pull request #237 from HerculesWS/warnings

This adds an Xcode project file (for those who develop on OS X) and fixes several - potential or real - issues we detected thanks to its more strict warnings settings. It also updates the unix build script with similar warning settings.