Use a separate enum for public error codes, and document the public functions.
Add a few more error reasons.
Remove an unused include.
Switch to a bool 'success' result.
Revert of Add a whole-app-list unit test. (https://codereview.chromium.org/210083009/)

Reason for revert:
This patch broke 'sizes' by adding a static initializer. Seehttp://build.chromium.org/p/chromium/builders/Linux/builds/48686/steps/sizes/logs/stdio for the detailed dump.

Original issue's description:
> Add a whole-app-list unit test.
> 
> This establishes a test harness for doing tests that touch on multiple
> parts of the app launcher UI, or that need coverage for the various app
> launcher configurations: Ash or Desktop; regular or experimental
> "landscape" mode.
> 
> It currently just tests displaying and closing the app launcher in its
> default state with a flat (no folders), 2- or 3-page model.
> 
> BUG=169114
> TEST=Added unit tests AppListViewTest{Aura,Desktop}.*
> 
> Previously committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260762
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260803

TBR=calamity@chromium.org,tapted@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=169114

Review URL: https://codereview.chromium.org/220873002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260826 0039d316-1c4b-4281-b951-d872f2087c98
Cleanup ManagePasswordItemView.

Just trying to understand the code; refactoring out some repetitive
ColumnSet declaration, and adding a number of comments to clarify things
for future generations.

BUG=261628

Review URL: https://codereview.chromium.org/213833009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260827 0039d316-1c4b-4281-b951-d872f2087c98
Updated chrome://power canvas to handle high dpi displays

OLD=http://i.imgur.com/qtE6kil.png
NEW=http://i.imgur.com/XLhYBvA.png

BUG=312956

Review URL: https://codereview.chromium.org/219423002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260828 0039d316-1c4b-4281-b951-d872f2087c98
Profile WebCore::CachedMatchedProperties in dmprof.

BUG=None
TBR=tasak@chromium.org
NOTRY=True

Review URL: https://codereview.chromium.org/220593002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260829 0039d316-1c4b-4281-b951-d872f2087c98
Move UpdateShortcutInfoAndIconForApp from web_app_ui to web_app

There's no particular need for this to be in web_app_ui. It's better
to unify this code into web_app.cc.

This refactor is necessary for http://crrev.com/205563005.

BUG=356889

Review URL: https://codereview.chromium.org/212273002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260830 0039d316-1c4b-4281-b951-d872f2087c98
Componentize SigninManager.

This CL does the following:

- Componentizes SigninIdAccountHelper, on which SigninManager depends
- Abstracts SigninManager's (embedder-level) calculation of whether to merge
  signin credentials into the cookie jar via SigninClient
- Eliminates the |profile| argument of SigninManagerBase::Initialize() now that
  SigninManager no longer needs it
- Componentizes SigninManager

BUG=334209,333998
TBR=thakis

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260636

Review URL: https://codereview.chromium.org/218713002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260831 0039d316-1c4b-4281-b951-d872f2087c98
Mojo: Implement MojoUnmapBuffer().

Still to do: more tests.

R=darin@chromium.org

Review URL: https://codereview.chromium.org/220113003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260832 0039d316-1c4b-4281-b951-d872f2087c98
Add flag to gather statistics from the Blink points-to graph.

This also fixes an error where the edge key of subclass edges was non-unique causing subclass edge entries to be incorrectly overwritten.

BUG=334149
NOTRY=true

Review URL: https://codereview.chromium.org/219213004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260833 0039d316-1c4b-4281-b951-d872f2087c98
Fix typo in MockSpellCheck::misspelledWords

Replace 'asd' into 'asdf' since editing/spelling/design-mode-spellcheck-off.html
is using it.
The test was always passing as it expects not to have spelling markers due to
<body spellcheck=false>

BUG=

Review URL: https://codereview.chromium.org/214153005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260835 0039d316-1c4b-4281-b951-d872f2087c98
Blink roll 170429:170525

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=170430:170525&mode=html

TBR=rafaelw@chromium.org
BUG=

Review URL: https://codereview.chromium.org/218403005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260837 0039d316-1c4b-4281-b951-d872f2087c98
Update .DEPS.git

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260838 0039d316-1c4b-4281-b951-d872f2087c98
Fix a crash of Chrome Shell when signing in.

If there are no google accounts registered in a device, Chrome Shell crashes when it attempts to sign in.
Because the length of |mAccounts| becomes 0.
So trying to take an account in |mAccounts| leads to an "out of index range" situation.

Review URL: https://codereview.chromium.org/208323009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260839 0039d316-1c4b-4281-b951-d872f2087c98
Update V8 to version 3.26.2 (based on bleeding_edge revision r20370).

TBR=jochen@chromium.org

Review URL: https://codereview.chromium.org/220363003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260840 0039d316-1c4b-4281-b951-d872f2087c98
Update .DEPS.git

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260841 0039d316-1c4b-4281-b951-d872f2087c98
Returning data removal warning string.

BUG=358295
NOTRY=true

Review URL: https://codereview.chromium.org/220113005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260843 0039d316-1c4b-4281-b951-d872f2087c98
Move Preload() code to MappedFile

To heat up the file system caches we load the disk cache index 
into RAM when starting the browser. To make it more obvious
what we're doing, move that to a method named Preload().

BUG=None
R=rvargas@chromium.org

Review URL: https://codereview.chromium.org/206453003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260844 0039d316-1c4b-4281-b951-d872f2087c98