Ruby Rogues feedback

Ruby Rogues recently did a [code reading of dotenv](https://www.youtube.com/watch?v=lKmY_0uY86s). It was really interesting. Unless you are one of the 5 people in the world that are as fluent in Ruby as @JEG2, there are definitely some interesting things to learn from it.

Most of their constructive criticism was around the `Dotenv.with` method, which is an internal helper that was added in c11eb70646cd44a58b62fa15205a3ce2336f2331 just to remove some duplication. This attempts to fix some of their gripes.

/cc @JEG2 @cmaxw @dbrady
On 08/15/2014 07:35 AM, Brandon Keepers wrote:
> They suggest using |#each_with_object|, introduced in Ruby 1.9, but 
> not only do I find it to be a long and ugly name

With use it has become more familiar to me, but I totally agree. When I 
first saw each_with_object I was not a fan. I like `each.with_object` 
better but that doesn't work when people write custom `each` methods 
that don't return an Enumerator. This happens often enough that I never 
use the `.with_object` form, even though it's much more elegant to me, 
because I have to think each time I use it: "can I trust this to be 
available?". :-( But yeah, 1.8 compatibility trumps the whole argument. :-)

+1 to what James said, this was fun code to read and was a huge learning 
experience for me. I really enjoyed it, and my rants were aimed at 
general ruby syntax and customs, not at you or your code. Thank you for 
writing it!

David

-- 
David Brady
dbrady@shinybit.com
We enter this world naked, bloody, and screaming. That sort of thing doesn't have to end there if you know how to live right. -- Dana Gould