replace sale_item_creator with a product_param object
rubocop fixes for product.rb