added and refactored tests in offers controller spec