commit
Finish values/combinations generation