On Thu, May 22, 2014 at 02:19:13PM -0700, Ryan Faulkner wrote:
> > +                           r['HEAD'].tree)):
> > +        if not change[0][0]:
> > +            tracked_changes['add'].append(change[0][1])
> > +        elif not change[0][1]:
> > +            tracked_changes['delete'].append(change[0][0])
> > +        elif change[0][0] == change[0][1]:
> > +            tracked_changes['modify'].append(change[0][0])
> > +        else:
> > +            assert False    # path names different; move ops not yet supported
> > +    return tracked_changes
> > +
> > +
> > +def get_unstaged_changes(repo):
> > +    """Walk through the index check for differences against working tree.
> > +
> > +    :param repo:                repo path or object
> 
> It's confusing to point out several instances where whitespace is not to a standard rather than stating that standard.  
Sorry, I agree those comments were too vague.

> It seems the rule is:
> 
> """<docstring>\n\n(:param <param_name>:\w<param_name>\n)*(:return:\w<return_doc>\n)+"""
> 
> I was using tabs instead of single-space.  I'm now conforming to the above pattern as it seems to be the pattern throughout the project.  Please advise if this is not the case.
Please don't use tabs in Python code - see PEP8.
http://legacy.python.org/dev/peps/pep-0008/#tabs-or-spaces

Dulwich doesn't use more than one space in argument documentation in docstrings anywhere at the moment.

% grep -h "param " dulwich/**/*.py  | grep ":  " | wc -l
0

Cheers,

Jelmer

-- 
Jelmer Vernooij <jelmer@debian.org>
Debian Developer                           http://samba.org/~jelmer/