BidderInterface: the AgentConfig is now passed as a parameter to all the...

... functions
Yes, whatever notion is inferred by the BidderInterface, it still needs to
be linked with the router.
This is not RTBkit 2.0 just yet.

On Thu, Oct 16, 2014 at 2:11 PM, oktal <notifications@github.com> wrote:

> In rtbkit/plugins/bidder_interface/bidder_interface.mk:
>
> > @@ -1,9 +1,9 @@
> >  $(eval $(call library,agents_bidder,agents_bidder_interface.cc,rtb_router))
> >  $(eval $(call library,http_bidder,http_bidder_interface.cc,rtb_router openrtb_bid_request))
> > -$(eval $(call library,multi_bidder,multi_bidder_interface.cc,))
> > +$(eval $(call library,multi_bidder,multi_bidder_interface.cc,rtb_router))
>
> What are we claiming ? If you take the HttpBidderInterface, it is still
> tightly coupled to the router (to inject bids back in the router for
> example), so I can't really remove the rtb_router dependency here.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/datacratic/rtbkit/pull/94/files#r18974498>.
>