is this the right way to do this?