add some tests around when notifications should happen