All,

> We have debug() available, should we use that instead of console.log? Or do we want this visible all of the time, and not just when debug is enabled?

I was debating that as I coded it up. In that the system already logs out some of the gets and 404s all the time (console.log instead of debug) and thinking through that it’s the sort of “error” that is easily fixable when you are aware of it, and then it goes away - I figure console.log is a bit better choice.


As far as log gin the err2 message I debated about that too. What was currently being shown when they error wasn’t being handled and thrown all the way up to whatever was printing it out, wasn’t very helpful in terms of figuring out what the missing resource was, so I opted to not include it.   Also, the error resulted in an ENOENT error from an fs.stat somewhere and that seems to display regardless of the logging at this point.

So that’s my two cents worth (and why I did it the way I did) but if y’all want debug() and showing err2 I can do it.


Jeff Moyes

UX - Web Developer
jeffmoyes@familysearch.org<mailto:jeffmoyes@familysearch.org>






On Mar 12, 2014, at 8:00 AM, Logan Allred <notifications@github.com<mailto:notifications@github.com>> wrote:


In lib/assets.js:

> @@ -68,6 +68,9 @@ aproto.getRequestPath = function getRequestPath() {
>  };
>
>  aproto.getDiskPath = function getDiskPath() {
> +  if(this.isPassthrough) {
> +    console.log('Asset-Manager can not find a resource on disk - and might blow up. The original request was for: ', this.origRoute, ' and this has been ammeded to ', this.route, '\n', '\n' );


We have debug() available, should we use that instead of console.log? Or do we want this visible all of the time, and not just when debug is enabled?

—
Reply to this email directly or view it on GitHub<https://urldefense.proofpoint.com/v1/url?u=https://github.com/fs-webdev/asset-manager/pull/45/files%23r10518026&k=wlPCrglRP6kzT4RbABWMaw%3D%3D%0A&r=yk5TyJVRXOcuCYlTvnFLf%2F2%2B2WQ1W0qFzJiFEK2zeDg%3D%0A&m=94LlH%2BTgt4o9827%2BJ0JeXaxBbhnZeVpgs2dWQE0ksYw%3D%0A&s=a89de6c8b2717c99e0d18b5f1976a18a255a455ca2c92c08452c4d5b957f74a0>.


 NOTICE: This email message is for the sole use of the intended recipient(s) and may contain confidential and privileged information. Any unauthorized review, use, disclosure or distribution is prohibited. If you are not the intended recipient, please contact the sender by reply email and destroy all copies of the original message.