kill: fix coding style

The kill was deprecated at the time lot of other tools got style
unification.  Now when deprecation is lifted it is time to get kill
cleaner.  This commit does not modify code, only various spacing issues,
removal of unecessary braces, and such are dealt.

Signed-off-by: Sami Kerola <kerolasa@iki.fi>
kill: flip all comparions to be in smaller - greater order

This makes code more readable.

Signed-off-by: Sami Kerola <kerolasa@iki.fi>
kill: move magic numbers in beginning of the file

Signed-off-by: Sami Kerola <kerolasa@iki.fi>
kill: make usage() not to return

And change the function argument to be an output stream.  Earlier the
--help option made kill exit with none-zero value, that is now corrected.

CC: Benno Schulenberg <bensberg@justemail.net>
Signed-off-by: Sami Kerola <kerolasa@iki.fi>
kill: deprecat invocation as 'pid' command name

Enabling options by renaming command is both unexpected and undocumented.
This magic is now deprecated and with remark of removal of this
functionality in future.

Signed-off-by: Sami Kerola <kerolasa@iki.fi>
kill: use control structure to pass user input to functions

This should make it easier to understand how the program works.

Signed-off-by: Sami Kerola <kerolasa@iki.fi>
kill: tell what is wrong rather than output usage()

Getting usage as error message is not specific enough.  As a user I want
to know what is wrong, and if it is unclear after error message how to
recover then I run command with --help.

Signed-off-by: Sami Kerola <kerolasa@iki.fi>
kill: add parse_arguments() function

Long main() is difficult to read, so moving argument parsing to separate
function should make sense.

Signed-off-by: Sami Kerola <kerolasa@iki.fi>
kill: move sigqueue inputs to control struct

Use of global variables is messy.  The earlier implementation also
assumed queue argument never to be textual, such as 'HUP', which now
works as one might expect.

Signed-off-by: Sami Kerola <kerolasa@iki.fi>
libsmartcols: clean up flags usage

 * rename flags functions to scols_table_enable_*
 * rename *_no_foo() functions to _nofoo()
 * output formats are mutually exclusive, so don't use flags there
 * don't assume symbols in scols_new_table(), use scols_table_set_symbols()

Signed-off-by: Karel Zak <kzak@redhat.com>
build-sys: small fixes to libsmartcols

Signed-off-by: Karel Zak <kzak@redhat.com>
libsmartcols: fix test

Signed-off-by: Karel Zak <kzak@redhat.com>
libsmartcols: add missing COPYING file

Signed-off-by: Karel Zak <kzak@redhat.com>
switch_root: verify initramfs by f_type, not devno

As of linux 3.14, the initramfs device will have both major and
minor 0, causing our paranoia check to fail. Make this version agnostic
by checking the filesystem type, rather than a device number.

Signed-off-by: Dave Reisner <dreisner@archlinux.org>
libfdisk: make qsort_r() optional

The function is no critical for fdisk functionality. The SUN label
verification will check for less issues. All the verification code is
optional ('v' fdisk command).

Signed-off-by: Karel Zak <kzak@redhat.com>
Merge branch 'kill' of git://github.com/kerolasa/lelux-utiliteetit

* 'kill' of git://github.com/kerolasa/lelux-utiliteetit:
  kill: move sigqueue inputs to control struct
  kill: add parse_arguments() function
  kill: tell what is wrong rather than output usage()
  kill: use control structure to pass user input to functions
  kill: deprecat invocation as 'pid' command name
  kill: make usage() not to return
  kill: move magic numbers in beginning of the file
  kill: flip all comparions to be in smaller - greater order
  kill: fix coding style
kill: reorder functions to make it more readable

Signed-off-by: Karel Zak <kzak@redhat.com>
kill: rename printsignals() to print_all_signalsprint_all_signals()

Signed-off-by: Karel Zak <kzak@redhat.com>
docs: add pid alis to deprecated.txt

Signed-off-by: Karel Zak <kzak@redhat.com>
kill: rename printsig() to print_signal_name()

Signed-off-by: Karel Zak <kzak@redhat.com>