[ticket/12388] Fix translation of log entries without additional log data

PHPBB3-12388
[ticket/12388] Add tests for lang() use on log actions without data

PHPBB3-12388
Merge pull request #2286 from nickvergessen/ticket/12388

[ticket/12388] Fix translation of log entries without additional log data

* nickvergessen/ticket/12388:
  [ticket/12388] Add tests for lang() use on log actions without data
  [ticket/12388] Fix translation of log entries without additional log data
[feature/only-op-can-view] ACP language keys and SQL data

Include the f_read_other permission in the DB. Defaults to true
Two new roles:
- ROLE_DESCRIPTION_FORUM_STANDARD_NO_OTHER <-like standard without f_read_other
- ROLE_DESCRIPTION_FORUM_LIMITED_NO_OTHER <-like limited without f_read_other

Altering other "f_" ROLES so that they include the f_read_other as true (1)

Added the language keys for f_read_other (requires adding a tab before all "=>"

PHPBB3-10624
[feature/only-op-can-view] Adding ACP language keys

Adding the language keys  for the ACP roles systema and explanation about each
role.
The big amount of lines changed is caused by a need to add a tab before "=>" in
all lines so that all the "=>" may match from line to line

PHPBB3-10624
[feature/only-op-can-view] Bug fix: git destroyed permissions.php

This is the fix to remove the file git destroyed caused by a misplaced head.
This removes the git marks and the previous version form the file.

PHPBB3-10624
[feature/only-op-can-view] Apply to feeds.php

After applying this feature to the ACP, now the feature is also applied to
the feeds.php.
Many tests were made to make sure that it is working as it should. Please
test and confirm that all is working properly.

PHPBB3-10624
[feature/only-op-can-view] Follow code guidelines in feeds.php

There was a mistake in feeds.php where it wasn0t following the coding
guidelines.

PHPBB3-10624
[feature/only-op-can-view] Viewforum Edit. Apply this to viewforum

- New template variable to forumlist_body.html -> FORUM_PRIVATE
- forumlist_body.html tweaked:
 - If the user can only see his posts then:
  - He cannot see the number of posts. -> "?" appears
  - He cannot see the number of topics. -> "?" appears
  - He cannot see the last post. Finding it would create a significant overhead
    caused by both PHP and DBMS processing. May be added in the future as an
    option. Anyway, this is the way most other forums act.
- viewforum.php:
 - If the user has limited access, the topic recount is used.
 - To prevent too much overhead by many if's, if sort_days exist, then solve
   everything in 1 if. Probably the code can be considered cleaner this way.

- New language key "PRIVATE_FORUM_FORUM".
 - Used to replace the last post date, image link and author in
   forumlist_body.html

Notes:
 Announcements and global announcements are not filtered. This is no bug, this
 is made like that by design. It's useful for the forum admins/mods to be able
 to post topics in a way everyone can see.

 Unless there's a bug, it's now officialy impossible to get to every single post
 that can exist in a forum though viewforum (not search.php)
 if you don't have the right to see other's posts.
 Same happens for the real number of posts, the last poster of the forum,
 the number of topics and any other information that can lead to people
 thinking or finding out that there are more posts inside that forum than
 announcements, global announcements and topics they started by (him/her)self.

PHPBB3-10625
[feature/only-op-can-view] Feeds changes

Improved a comment to be more expressive.
After some discussion, it was decided that news should also be filtered.

PHPBB3-10625
[feature/only-op-can-view] The search.php edits

search.php seems to be completly "sealed"
My search shows that all that only-op-can-view is now completly applied to
search.php now.

PHPBB3-10625
[feature/only-op-can-view] Altering forum listing

I was suggested a while ago to do this but I had forgotten. Now I have applied
the suggested changes. Make it show just like it shows with links
replacing forums (a forum of type link). This also allows not to use the '?'.
Is this way ok?

PHPBB3-10625
[feature/only-op-can-view] Applying to the posting page

This commit applies the "protection" needed for posting.php by the time this
commit is made.
These changes are simple and work much like the reading permission.

PHPBB3-10623
[feature/only-OP-can-view] Limit the forums shown to the user in display_forums

This update applies the changes needed for this permission in functions_display
so that an unauthorized user cannot view the forums listed if he cannot see them
while watching the forums displayed

Note: I need help distinguish exactly if a specific part of the code leaks data
that might be against this permission's policy.
Search for:
"// Please check if this leaks data on letting users"
To find those parts and then comment please

PHPBB3-10623
[feature/only-OP-can-view] Force field functions_posting.php

Applied the change to functions_posting.
It now prevents the user from viewing the topic link if he should not be able
to see it.
Also it checks if the user still has permissions to load a draft just like it
 is made with f_read permission.

For topic_review(), It applies the standard adding the extra data for query to
 the DB in case the user does not have the permission to read all threads in
 the forum so that it can be confirmed that the user really can or cannot view
 those posts

For user_notification(), The rule applies, included the check for the user_id
 and the f_read_other everywhere the f_read exists and changed a bit the way
 the verifications work so that it becomes a bit more efficient and to be
 easier to execute the tests needed.

PHPBB3-10623
[feature/only-OP-can-view] Applying to the reporting system

With this, the reporting system is now shielded.

This is just a check for permissions in each file related to reports.

PHPBB3-10623
[feature/only-OP-can-view] filtering in display activity

If the user is not allowed to know the topic exists, then he may not know that
the place where the given user has been more active is that hidden topic.

PHPBB3-10623
[feature/only-OP-can-view] The MCP main module pack

This includes all the changes made to the main module of the MCP.

It is resumed to only adding a simple check for the new permission.

PHPBB3-10623
[feature/only-OP-can-view] MCP logs, queue and warn are now filtered

This is the conclusion of the MCP filtering.

In the mcp_queue it is also a bugfix. A previous commit had
sql_in_set('f.forum_id', $forum_all_readable_list) where f.forum_id should be
t.forum_id

PHPBB3-10623
[feature/only-OP-can-view] Bugfix: viewtopic & functions_posting

includes/functions_posting.php had a variable with the wrong name.
The result would be undefined variable and an always false. It's fixed.

In viewtopic.php, the normal user without this permission was being blocked
from viewing global or forum announcements. This is now fixed.

PHPBB3-10623