Remove extraneous ERROR messages where they give no extra information

This will help to reduce the debug.log output in some cases by two unnecessary additional lines.

(debug=mempool will need to be in bitcoin.conf to ensure the error is still captured in debug.log)
This string can be rather long sometimes. The full string is shown upon
initial connection in the log.
On Sep 25, 2014 4:32 PM, "Wladimir J. van der Laan" <
notifications@github.com> wrote:

> In src/main.cpp:
>
> > @@ -3820,9 +3820,8 @@ bool static ProcessMessage(CNode* pfrom, string strCommand, CDataStream& vRecv,
> >          int nDoS = 0;
> >          if (state.IsInvalid(nDoS))
> >          {
> > -            LogPrint("mempool", "%s from peer=%d %s was not accepted into the memory pool: %s\n", tx.GetHash().ToString(),
> > -                pfrom->id, pfrom->cleanSubVer,
> > -                state.GetRejectReason());
> > +            LogPrintf("mempool: %s not accepted from peer=%d %s: %s\n", inv.ToString(),
> > +                pfrom->id, pfrom->cleanSubVer.substr(0,20), state.GetRejectReason());
>
> Isn't the point of cleanSubVer already that it is cleaned for logging
> purposes? I don't see the point of doing another substr() here.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/bitcoin/bitcoin/pull/4848/files#r18020393>.
>