Yes

 

$t_rows, $row are also other candidates. I’ve just been trying to do things in a way that it’s possible for me to diff against the old next/master-2.x branch that I’m pulling changes from, whilst having some level of certainty of not breaking stuff.

 

Whilst it’s painful, given that I think we would like to follow a standard – my personal view is that it’ll be less painful to get to that standard then keep finding random bits not matching the standard and wanting to fix them.

 

We previously changed our file header to do like google are doing with Chrome/Chromium etc to just show:

* @copyright Copyright 2002  MantisBT Team - mantisbt-dev@lists.sourceforge.net

 

Outcome of this – we didn’t need a commit in January to update the year in every file in the code base.

 

From: Victor Boctor [mailto:notifications@github.com] 
Sent: 05 April 2014 06:39
To: mantisbt/mantisbt
Cc: grangeway
Subject: Re: [mantisbt] Mantis 2.0 - Database Layer Patch (#156)

 

In core/print_api.php:

> @@ -1044,19 +1033,16 @@ function print_project_user_list_option_list( $p_project_id = null ) {
>   * @param int $p_user_id user id
>   */
>  function print_project_user_list_option_list2( $p_user_id ) {
> -     $t_mantis_project_user_list_table = db_get_table( 'project_user_list' );
> -     $t_mantis_project_table = db_get_table( 'project' );
> -
>       $c_user_id = db_prepare_int( $p_user_id );
>  
>       $query = "SELECT DISTINCT p.id, p.name

Are you going to do a $query to $t_query replacement?

—
Reply to this email directly or view it on GitHub <https://github.com/mantisbt/mantisbt/pull/156/files#r11320170> .  <https://github.com/notifications/beacon/434241__eyJzY29wZSI6Ik5ld3NpZXM6QmVhY29uIiwiZXhwaXJlcyI6MTcxMjI5NTUxMiwiZGF0YSI6eyJpZCI6MjkzMzYwNTJ9fQ==--05d23a8e0e7062ebd8fc334ccba4cf62267bad58.gif>