addressed review comments

Change-Id: I4e270b70462bd04f575cc43ea9c5e53169a50fb7
:) that's where I had originally, your comment was to put it in retry as some times nova commands fail...


From: opencontrail-ci-admin <notifications@github.com<mailto:notifications@github.com>>
Reply-To: Juniper/contrail-infra-config <reply@reply.github.com<mailto:reply@reply.github.com>>
Date: Wednesday, September 3, 2014 at 1:06 PM
To: Juniper/contrail-infra-config <contrail-infra-config@noreply.github.com<mailto:contrail-infra-config@noreply.github.com>>
Cc: Kamlesh Parmar <kparmar@juniper.net<mailto:kparmar@juniper.net>>
Subject: Re: [contrail-infra-config] addressed review comments (#32)


In modules/jenkins/files/slave_scripts/ci-infra/launch_vms.rb:

> @@ -149,6 +151,14 @@ def Vm.create_internal(vmshort_name, vmname, floatingip, metadata, flavor)
>              sleep 10
>          }
>
> +        1.upto(6 * 30) { # at most 30 minutes
> +            hostname, e = Sh.carun "nova show #{uuid} | \grep OS-EXT-SRV-ATTR:host | awk '{print \\$4}'"
> +            if hostname =~ /[a-zA-Z0-9_-]*/ then
> +                break
> +            end
> +            sleep 10
> +        }
> +


Hi,

Can you please merge your logic to the loop already present. We should the IP address, hostname, etc. in one go from nova show output.

-
Reply to this email directly or view it on GitHub<https://github.com/Juniper/contrail-infra-config/pull/32/files#r17076027>.