modify for string length