Irwin lastl

I will add a more comprehensive test.

On Oct 15, 2014, at 11:52 PM, Daniel Park <notifications@github.com> wrote:

> In test/test_taxon_filter.py:
> 
> > @@ -15,3 +20,39 @@ class TestTaxonFilter(unittest.TestCase):
> >  	def testNothingAtAll(self):
> >  		'''here we test nothing at all and this should pass'''
> >  		pass
> > +
> > +
> > +filterLastalInput = """@fakeRead
> > +AGTACATGCAGAGCAAGGACTGATACAATATCCAACAGCTTGGCAATCAGTAGGACACATGATGGTGA
> > ++
> > +CCCFFFFFHHHHHJJJJJJJJJJJJJJJHIIIIJJJJHIJIIJJIJJFHGIIJJGHHHBDFDDDDDDD
> > +"""
> > +filterLastalExpected = """@fakeRead
> > +AGTACATGCAGAGCAAGGACTGATACAATATCCAACAGCTTGGCAATCAGTAGGACACATGATGGTGA
> > ++fakeRead
> > +CCCFFFFFHHHHHJJJJJJJJJJJJJJJHIIIIJJJJHIJIIJJIJJFHGIIJJGHHHBDFDDDDDDD
> > +"""
> > +
> > +class TestFilterLastal(unittest.TestCase):
> Nice simple test. It seems to run on a single sequence of input and verify that it passed through the other side untouched. Perhaps at some point add a second test that has one sequence that doesn't make it through to the other side, for good measure? (that way "cat" doesn't pass our unit tests as a drop-in replacement for lastal).
> 
> —
> Reply to this email directly or view it on GitHub.
>