Use assertIn where appropriate

Change-Id: I27038279067183352e5a54766fb74515057d581a
Misc typo in neutronclient

Added a missing description for parameter node in the
docstring of function _from_xml_node

Change-Id: I4534dbf43e45b94d44d0c53d910987b8fad1cbdf
Closes-Bug: #1255994
Add -U to pip install command in tox.ini

Ask pip to upgrade packages in the virtualenv so that a long-lived
virtualenv is still kept up to date as external dependencies change.

Change-Id: I0256cf4cc3aa7675956762dcf056e2709d36813a
Merge "Add -U to pip install command in tox.ini"
Remove start index 0 in range()

Remove the useless arg ("start index" = 0) in files, since its default
value is 0, to make code cleaner.

Fixes bug #1261580

Change-Id: Ieeace91e8cbd540ddccd8288002331a6e5a70c58
Remove a debugging print statement

This seems useless, and it's a syntax error in Python3.

Change-Id: I699186b73b2208cccb958335d55912066172f4ff
Remove an unused imported module

The urlparse module is imported in neutronclient/client.py but not used, so we
can safely remove it.

Change-Id: Ia9e950e754d00ee4f28172f3e685b892748991e2
Merge "Remove start index 0 in range()"
Make compatible with Cliff (1.5.2)

The most recent version of cliff changes the way formatters work.  This
temporarily disables the custom formatter to get the gate working
again.

Partial-Bug: #1265926
Change-Id: Id0fe9ca3ddf0326a88055f8767de4cbe4cadb950
Fix description of ListSubnet

The help texts for both "neutron net-list" and "neutron subnet-list"
give the same text "List networks that belong to a given tenant."

Fix it so that subnet-list output the proper "subnet"

Change-Id: I0877b51ad10ac0e04b24effa7cbd1e412098e363
Partial-Bug: #1244618
Merge "Remove an unused imported module"
Merge "Misc typo in neutronclient"
Merge "Fix description of ListSubnet"
Mention --fixed-ip subnet_id=<..> in help message

Improved help message for port-create --fixed-ip subnet_id=<..> case:
 * ensure it's mentioned when no arguments are passed;
 * fixed wording of --help message to make it clear subnet_id may be
   passed without ip_address.

Change-Id: Ie48099e0445f80dbff78766e42bc548f925cd208
Closes-Bug: #1267465
Combine debug and verbose commandline options

Most of the openstack clients (for example nova) when --debug is specified it
shows the api calls the client is making. However, when debug is passed into
the neutronclient it shows exceptions that have occurred inside the
neutronclient. This patch combines verbose and debug to do the samething.

Change-Id: I6f2e0b17ffbe8fbfa77e26222dae32f5ab1e8866
Closes-bug: #1260489
Adding weight column to Neutron lb member list CLI

Adding 'weight' column to lbaas member-list command in order to quickly
identify member properties. Protocol port was already been shown.
This avoids having to enter each member details to see the weights
settings.

Change-Id: Id3c8cd8b3304535e2d82777018121007ed3bb129
Closes-Bug: #1267575
update coveragerc file

fix missing change from quantumclient to neutronclient in .coveragerc
exclude tests from code coverage calculation

Change-Id: Ie286faaaaad9e9bc72c89422ac628178a30ccc8e
session_persistence: invalid str2dict value: u''

Can't receive empty session_persistence dict to update the vip.
It would raise the following error:

$ neutron lb-vip-update vip --session_persistence type=dict ""
usage: neutron [--session_persistence SESSION_PERSISTENCE]
neutron: error: argument --session_persistence: invalid str2dict value: u''

Change-Id: Ice43bbe19138be6af85b47c2090359d22c70b29f
Closes-Bug: #1262582
Rename Nicira NVP to VMware NSX in neutronclient

Use new naming scheme to reflect rebranding.

Partial-implements blueprint nicira-plugin-renaming

Change-Id: I694fbda1c228e92a0b910358523787fa742d9ab2
Add shared parameter for metering labels

With this patch metering labels can
be set as shared so that the rules
associated with this label will be
applied to all routers for all tenants.

Partially implements
blueprint l3-metering-mgnt-ext

Change-Id: I23f9fb9cf17c7a20069616bb1c4ae19a5dc55d68