break out path building logic to methods
extract path building to a method
Fix broken list formatting [ci skip]
subclass Rails::Engine
Merge pull request #16201 from noinkling/master

Fix broken list formatting in API docs [ci skip]
Remove need for macro instance var

Same as we did for collection, removed the `@macro` instance var
and it is now set in each association. Unfortunately it can't be
left undefined in AssociationReflection so it has to be set there.
For now I am setting it to NotImplementedError since there is no
default macro and it changes based on the reflection type.