AFAICT, the `id` argument is always `attr::mk_attr_id()`: it would be better to just not have the argument and call that in here.