Remove unused variable

o heat/common/config.py:DEFAULT_PORT = 8000

  This variable was removed in the following commit.

    commit 34e47b64d926c055d9895c5b3f27949eaca68999
    Author: Steve Baker <sbaker@redhat.com>
    Date:   Mon Jul 22 16:01:44 2013 +1200

        Move heat-cfn, heat-boto, heat-watch to new repo

Change-Id: Iab6213eba1422882c92bd16a3351df19869aa9f3
Set statuscode=404 in NotFoundException in tests

when resource can'n be found,neutron will set
statuscode=404 in NotFoundException,so add statuscode
in exception to make fake client have same action.

Change-Id: I6597f080903501d9fe6050893054cc7dba6a595b
Make the first line of every file consistent.

Change-Id: I2e1a809cfca8e88693551d58d33e747f54ee5eb1
Add IP address to error message of failed stack

The error message that occurs when the heat-script.sh or cfn-userdata
script runs doesn't include the IP address of the server, and it's not
possible to find that info in the stack-show output of a failed stack.
Add the IP address to the error message so it is displayed in the
stack-show output to aid in debugging.

Change-Id: I35bd4fbc1a05fa8207f3eb4f501f5becf78415c9
Ensure that the NoCloud data source is loaded, part 2

The cloud-init config is now in /etc/cloud/cloud.cfg.d/90_dpkg.cfg
instead of /etc/cloud/cloud.cfg.d/10_rackspace.cfg, and that caused bug
1285891 to resurface.

Change all files in /etc/cloud/cloud.cfg.d to make this somewhat
future-proof.

Change-Id: I65e2c0795952a5807783bf272061550a4a3447e0
Closes-Bug: #1288920
Closes-Bug: #1285891
Fix start_with_acquired_lock - pass kwargs to func

This method of ThreadGroupManager was not passing kwargs
to the function to be started.

Closes-Bug: #1288627
Change-Id: Icaaa012bcc65c67f3e8ecc2878dee2a78121e357
Add more unit tests for ThreadGroupManager

this patch adds unit tests for the rest of ThreadGroupManager methods.
Related-Bug: #1288627
Change-Id: I38a0864c649d1693ef4fb5b49d5aeb37632263ca
Fix InternalException raised on stack-show

Getting attributes of a OS::Nova::Server raises a 500 error if the server
doesn't exist. So stack show doesn't work. We should catch the exception
and return the default values of the output keys of the server while
getting attributes to make sure the api works.

Change-Id: If569b4d73abbce93d3c56c45a1eb284720c6e416
Closes-Bug: #1279085
Remove unused versions define in template_format.py

Remove unused 'HEAT_VERSIONS' and 'CFN_VERSIONS' define in
template_format.py.

Change-Id: Icb6920fa481259868b6bf2feaab9859a13c59467
Allow update of disable_rollback

Previously, any change to disable_rollback was ignored during
stack-update.

Change-Id: I76aaf5be379dab5347e392392b2334ab1d8749b0
Closes-Bug: #1290943
Removing unnecessary required=True options

Property with a default value should not have required=True,
since it has no effect (the default value would be used if a property
were not given, making it not required).

Change-Id: I760ed5c010c9ff3c0e4dc0fc7860f1e18147921d
Refactor Template.parse()

Split out Template.parse() as a separate function. This saves an expensive
method call to self.functions() for every potential intrinsic function in
the template, plus makes a template parsing routine available to other
parts of the code that may want to use it, without being tied to a
Template's ideas of what the intrinsic functions available are.

Change-Id: I1d4b847967357dbe5c9960223a063377aec50e5d
Default properties to the empty dict in ResourceGroup

Sets the properties of the grouped resource to {} when it's None to make
sure the resource is built properly.

Change-Id: I2938c741063159ef81a7996d203adaf466cf19c4
Closes-Bug: #1291421
KeyError generated when using a provider template

The function for registering information about provider templates
referenced via urls is causing a KeyError. This patch checks for
checks for the existance of the specified resource befor removing
from the registry. This will prevent KeyErrors in stacks referencing
provider templates that are persisted in the database.

Partial-Bug: #1288541
Change-Id: Id58d5bfeac896d0d52eb4262b25eff3a5fe2238c
Reimplement L3Agent as router's property

We implemented Neutron's L3Agent resource as Heat's RouterL3Agent resource at
once.

  https://review.openstack.org/#/c/61388/

However, that model can change the router_id when doing stack-update.
The bug 1272254 was caused by that model.

We discussed about how to resolve the bug 1272254 with the Heat community.
The conclusion is to remove RouterL3Agent, then to reimplement agent_id as
router's property. This model can't change router_id. So its model can resolve
the bug.

Closes-bug: #1272254
Change-Id: Id9f75920ec46ec32f3e41bdb97f89a7fd09490ec
Order imports in alphabetical order (4/9)

This patch is one in a series to re-enable H306 style check rule
(imports are in alphabetical order). It touches db files.

Implements: blueprint reduce-flake8-ignored-rules (partial)
Change-Id: I66842c6a5d112f948e625e18ef6d01afcad61e57
Replacing NetworkGateway when devices updated

Updating OS::Neutron::NetworkGateway failed when devices property changed.

Currently, NetworkGateway's devices property doesn't have update_allowed=True.
So, UpdateReplace have used when updating devices property.
However, Neutron doesn't allow that same Gateway Services ID exist at a time.
Eventually, 409 error occured by Neutron.

For avoiding above error, I implemented replacing NetworkGateway in handle_update.
The processing order is delete -> create. It can avoid the 409 error.

Change-Id: I4021610355d03eb6ca07272cb1e44ff2b31dfff9
Closes-bug: #1291901
remove attributes from OS::Heat::AutoScalingGroup

The InstanceGroup attribute was inherited from the InstanceGroup
resource, but not implemented properly by OS::Heat::AutoScalingGroup. This
patch makes OS::Heat::AutoScalingGroup explicitly declare no attributes.

Change-Id: Iacf90b4590551a257ddd5442f28872e712da6c88
Closes-Bug: #1291789
Add events for automation statuses to Cloud Server

Previously, it was difficult to know if the server was stuck in
CREATE_IN_PROGRESS or if it was waiting for another automation to
complete.

Change-Id: I988a12fc520629a78d8215d4a9c529729a302741
Refactor CLB to work with groups

The Rackspace CLB resource couldn't be used with resource groups
because nodes were individual IPs or references. This change
allows a node to have a list of ips for a given port, status,
etc so that references to resource groups can easily be added
to Rackspace CLB instances. Ref-based nodes were removed as they
aren't used.

Change-Id: Ia26a012758fb1cd0470c1c0edc27e61e77bd8f0a