finished writing rspec tests for now