Break activity action filters up into groups in Activity admin. (We'll likely expand on this further with helper functions and more appropriate labeling later.)

git-svn-id: https://buddypress.svn.wordpress.org/trunk@8613 cdf35c40-ae34-48e0-9cc9-0c9da1808c22
Set group last_activity values explicitly in bp_group_is_user_banned() test

This ensures that they'll be loaded in the correct order during the
bp_has_groups() loop.

git-svn-id: https://buddypress.svn.wordpress.org/trunk@8614 cdf35c40-ae34-48e0-9cc9-0c9da1808c22
Skip the notorious `friends_register_activity_action` action in updated Activity admin type selector. (More to do here.)

git-svn-id: https://buddypress.svn.wordpress.org/trunk@8615 cdf35c40-ae34-48e0-9cc9-0c9da1808c22
In `messages_format_notifications()`, check that thread ID exists before attempting to link to it. Fixes debug notices and incorrect links when a message thread is deleted before notifications are marked as read.

git-svn-id: https://buddypress.svn.wordpress.org/trunk@8616 cdf35c40-ae34-48e0-9cc9-0c9da1808c22
In `bp_get_message_thread_view_link()`, check that thread ID exists before attempting to get a link to it. Fixes debug notices when a message thread is deleted before notifications are marked as read.

git-svn-id: https://buddypress.svn.wordpress.org/trunk@8617 cdf35c40-ae34-48e0-9cc9-0c9da1808c22
Clean up `messages_new_message()` to use `bp_parse_args()`.

Also re-allows previous functionality where members could respond to threads they are alone in. If someone wants to talk to themselves, who are we to stop them?

git-svn-id: https://buddypress.svn.wordpress.org/trunk@8618 cdf35c40-ae34-48e0-9cc9-0c9da1808c22
Add brackets to conditional statements in `bp-messages-functions.php`.

git-svn-id: https://buddypress.svn.wordpress.org/trunk@8619 cdf35c40-ae34-48e0-9cc9-0c9da1808c22
In `BP_Messages_Thread::is_valid()` add default value for `$thread_id` and perform an empty check inside the method. This allows `messages_is_valid_thread()` to return a proper result if an empty ID is passed into it.

git-svn-id: https://buddypress.svn.wordpress.org/trunk@8620 cdf35c40-ae34-48e0-9cc9-0c9da1808c22
Add brackets to conditions and do some general code clean up in `bp-messages-actions.php`.

git-svn-id: https://buddypress.svn.wordpress.org/trunk@8621 cdf35c40-ae34-48e0-9cc9-0c9da1808c22
Add default values to `bp_core_get_userid_from_nicename()` and `bp_core_get_userid()` so any usages without passed parameters do not cause debug notices (that's why those `empty()` checks are there, obvs.)

git-svn-id: https://buddypress.svn.wordpress.org/trunk@8622 cdf35c40-ae34-48e0-9cc9-0c9da1808c22
Clean up brackets and code formatting in `bp-members-functions.php`.

git-svn-id: https://buddypress.svn.wordpress.org/trunk@8623 cdf35c40-ae34-48e0-9cc9-0c9da1808c22
Use `bp_parse_args()` and remove `explode()` usage in `bp_core_get_users()`.

git-svn-id: https://buddypress.svn.wordpress.org/trunk@8624 cdf35c40-ae34-48e0-9cc9-0c9da1808c22
Add default static variable value in `_bp_get_user_meta_last_activity_warning()` and use it as a boolean instead of an integer.

git-svn-id: https://buddypress.svn.wordpress.org/trunk@8625 cdf35c40-ae34-48e0-9cc9-0c9da1808c22
Properly deprecate original notifications functions out of members component and back into core. This also paves the way for the members component to eventually have true notifications integration later, should that need ever arise.

git-svn-id: https://buddypress.svn.wordpress.org/trunk@8626 cdf35c40-ae34-48e0-9cc9-0c9da1808c22
Remove 'notifications' from Members component includes array; it was formally deprecated in 1.9 and in r8626.

git-svn-id: https://buddypress.svn.wordpress.org/trunk@8627 cdf35c40-ae34-48e0-9cc9-0c9da1808c22
When calling the deprecated `bp_core_get_notifications_for_user()` function, the `bp_core_get_notifications_for_user` filter is called two times: once in `bp_notifications_get_notifications_for_user()` and again `bp_core_get_notifications_for_user()`.

Here we remove the deprecated one and rely on the one in `bp_notifications_get_notifications_for_user()` to do its job.

git-svn-id: https://buddypress.svn.wordpress.org/trunk@8628 cdf35c40-ae34-48e0-9cc9-0c9da1808c22
Add conditional brackets and do some output type-casting in `bp_core_add_cropper_inline_js()`.

git-svn-id: https://buddypress.svn.wordpress.org/trunk@8629 cdf35c40-ae34-48e0-9cc9-0c9da1808c22
xProfile: when a user's profile is updated, correctly pass the fields' previous values to the `xprofile_updated_profile` action.

Fixes #5755, props Viper007Bond

git-svn-id: https://buddypress.svn.wordpress.org/trunk@8630 cdf35c40-ae34-48e0-9cc9-0c9da1808c22
xProfile: when updating a user profile, make sure the actions are passed the field's current (new) value.

Previously, we've been passing these actions the values that we've told xProfile to set, instead of the
field's actual (new) value. Most of the time, these will be identical, but with BP 2.0's xProfile field
type improvements, there are more lower-level places where the value could be filtered before the data's
written to the database.

In this situation, the field's actual new value could be different from what we've been returning in the
`xprofile_profile_field_data_updated` and `xprofile_updated_profile` actions.

See #5755

git-svn-id: https://buddypress.svn.wordpress.org/trunk@8631 cdf35c40-ae34-48e0-9cc9-0c9da1808c22