2011-05-04  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Eric Seidel.

        [results.html] Don't show actual failure type column for ports that don't use expectations files
        https://bugs.webkit.org/show_bug.cgi?id=60199

        For the most part, the links shown tell you what type of failure it is.
        The only case where we lose some information here is for a test that
        failed one run, but passed or had a different failure on retry.i
        We should probably put those tests in their own table anyways.

        * fast/harness/resources/results-test.js:
        * fast/harness/results.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@85778 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Windows DRT needs an implementation of shadowRoot
https://bugs.webkit.org/show_bug.cgi?id=59081

Add another test for the shadow dom to the Windows Skipped list to get the bots green.

* platform/win/Skipped:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@85779 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2011-05-04  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Anders Carlsson.

        WebKit2 flashes if entering and exiting compositing rapidly
        https://bugs.webkit.org/show_bug.cgi?id=60198

        If a page enters then immediately leaves compositing mode, the
        DrawingAreaImpl would send a message to the UI process that it
        had entered compositing even after all the layers had been torn
        down. Fix this by never sending the 'enter' message if we're
        waiting for the 'exit' timer to fire.

        Also fix an assertion in the UI process caused by sending mismatched
        'enter' and 'leave' messages by keeping track of which messages
        we've sent.

        * WebProcess/WebPage/DrawingAreaImpl.cpp:
        (WebKit::DrawingAreaImpl::DrawingAreaImpl):
        (WebKit::DrawingAreaImpl::layerHostDidFlushLayers):
        (WebKit::DrawingAreaImpl::exitAcceleratedCompositingMode):
        (WebKit::DrawingAreaImpl::exitAcceleratedCompositingModeSoon):
        * WebProcess/WebPage/DrawingAreaImpl.h:
        (WebKit::DrawingAreaImpl::exitAcceleratedCompositingModePending):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@85780 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2011-05-04  Chris Marrin  <cmarrin@apple.com>

        Reviewed by Simon Fraser.

        Crash in PlatformCALayer ::replaceSublayer when layer has not superlayer
        https://bugs.webkit.org/show_bug.cgi?id=60191

        Skip replaceSublayer when there is no superlayer rather than asserting.
        This is probably not a problem and happens when restructuring the layer
        tree. Avoiding this crash will allow us to get more testing.

        * platform/graphics/ca/GraphicsLayerCA.cpp:
        (WebCore::GraphicsLayerCA::swapFromOrToTiledLayer):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@85781 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[Chromium] Update bug numbers in media related test cases.
https://bugs.webkit.org/show_bug.cgi?id=60078

Reviewed by David Levin.

* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@85782 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2011-05-04  Anders Carlsson  <andersca@apple.com>

        Reviewed by Dan Bernstein.

        Can't save a link from "Save Linked File to Download" popup menu
        https://bugs.webkit.org/show_bug.cgi?id=60190
        <rdar://problem/9367927>

        Make sure that suggestedFilenameForResourceWithURL and resourceDataForFrame both look
        in the cache if the resource can't be found in the current web page. This matches WebKit1.

        * WebProcess/WebPage/WebFrame.cpp:
        (WebKit::WebFrame::suggestedFilenameForResourceWithURL):
        Call WebPage::cachedSuggestedFilenameForURL if we can't find a resource in the page.

        * WebProcess/WebPage/WebPage.cpp:
        (WebKit::resourceDataForFrame):
        Move code out from getResourceDataFromFrame.

        (WebKit::WebPage::getResourceDataFromFrame):
        Call resourceDataForFrame first and then cachedResponseDataForURL.

        * WebProcess/WebPage/WebPage.h:
        * WebProcess/WebPage/gtk/WebPageGtk.cpp:
        (WebKit::WebPage::platformHasLocalDataForURL):
        (WebKit::WebPage::cachedResponseMIMETypeForURL):
        (WebKit::WebPage::platformCanHandleRequest):
        (WebKit::WebPage::cachedSuggestedFilenameForURL):
        (WebKit::WebPage::cachedResponseDataForURL):
        Add stubs.

        * WebProcess/WebPage/mac/WebPageMac.mm:
        (WebKit::cachedResponseForURL):
        Add helper function.

        (WebKit::WebPage::cachedSuggestedFilenameForURL):
        (WebKit::WebPage::cachedResponseMIMETypeForURL):
        (WebKit::WebPage::cachedResponseDataForURL):
        Call helper function.

        * WebProcess/WebPage/qt/WebPageQt.cpp:
        (WebKit::WebPage::platformHasLocalDataForURL):
        (WebKit::WebPage::cachedResponseMIMETypeForURL):
        (WebKit::WebPage::platformCanHandleRequest):
        (WebKit::WebPage::cachedSuggestedFilenameForURL):
        (WebKit::WebPage::cachedResponseDataForURL):
        Add stubs.
        
        * WebProcess/WebPage/win/WebPageWin.cpp:
        (WebKit::cachedResponseForURL):
        Add helper function.

        (WebKit::WebPage::platformHasLocalDataForURL):
        (WebKit::WebPage::cachedResponseMIMETypeForURL):
        (WebKit::WebPage::cachedSuggestedFilenameForURL):
        (WebKit::WebPage::cachedResponseDataForURL):
        Call helper function.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@85783 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Unreviewed build fix.

Skipping test http/tests/navigation/response204.html for Mac, Win and GTK.

* platform/gtk/Skipped:
* platform/mac/Skipped:
* platform/win/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@85784 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2011-05-04  Tao Bai  <michaelbai@chromium.org>

        Reviewed by David Kilzer.

        Populate touch-icon url to FrameLoaderClient
        https://bugs.webkit.org/show_bug.cgi?id=59143

        * Configurations/FeatureDefines.xcconfig:
2011-05-04  Tao Bai  <michaelbai@chromium.org>

        Reviewed by David Kilzer.

        Populate touch-icon url to FrameLoaderClient
        https://bugs.webkit.org/show_bug.cgi?id=59143

        Parsed and populated apple-touch-icon url to FrameLoaderClient.
        Changed favicon to be a type of icon.

        * CMakeLists.txt:
        * Configurations/FeatureDefines.xcconfig:
        * GNUmakefile.am:
        * GNUmakefile.list.am:
        * WebCore.gypi:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * dom/Document.cpp:
        (WebCore::Document::iconURL):
        (WebCore::Document::setIconURL):
        * dom/Document.h:
        * dom/IconURL.cpp: Added.
        (WebCore::toIconIndex):
        * dom/IconURL.h: Added.
        (WebCore::IconURL::IconURL):
        * features.pri:
        * html/HTMLLinkElement.cpp:
        (WebCore::HTMLLinkElement::tokenizeRelAttribute):
        (WebCore::HTMLLinkElement::process):
        (WebCore::HTMLLinkElement::addSubresourceAttributeURLs):
        * html/HTMLLinkElement.h:
        (WebCore::HTMLLinkElement::RelAttribute::RelAttribute):
        (WebCore::HTMLLinkElement::isEnabledViaScript):
        * html/parser/HTMLPreloadScanner.cpp:
        (WebCore::HTMLNames::PreloadTask::relAttributeIsStyleSheet):
        * loader/DocumentLoader.cpp:
        (WebCore::DocumentLoader::iconURL):
        (WebCore::DocumentLoader::setIconURL):
        * loader/DocumentLoader.h:
        * loader/EmptyClients.h:
        (WebCore::EmptyFrameLoaderClient::dispatchDidChangeIcons):
        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::iconURL):
        (WebCore::FrameLoader::iconURLs):
        (WebCore::FrameLoader::fillIconURL):
        (WebCore::FrameLoader::getDefaultIconURL):
        (WebCore::FrameLoader::setIconURL):
        (WebCore::FrameLoader::didChangeIcons):
        * loader/FrameLoader.h:
        * loader/FrameLoaderClient.h:
2011-05-04  Tao Bai  <michaelbai@chromium.org>

        Reviewed by David Kilzer.

        Populate touch-icon url to FrameLoaderClient
        https://bugs.webkit.org/show_bug.cgi?id=59143

        Respected the change of FrameLoaderClient.

        * src/FrameLoaderClientImpl.cpp:
        (WebKit::FrameLoaderClientImpl::dispatchDidChangeIcons):
        * src/FrameLoaderClientImpl.h:
2011-05-04  Tao Bai  <michaelbai@chromium.org>

        Reviewed by David Kilzer.

        Populate touch-icon url to FrameLoaderClient
        https://bugs.webkit.org/show_bug.cgi?id=59143

        Respect the interface change in FrameLoaderClient

        * WebCoreSupport/FrameLoaderClientEfl.cpp:
        (WebCore::FrameLoaderClientEfl::dispatchDidChangeIcons):
        * WebCoreSupport/FrameLoaderClientEfl.h:
2011-05-04  Tao Bai  <michaelbai@chromium.org>

        Reviewed by David Kilzer.

        Populate touch-icon url to FrameLoaderClient
        https://bugs.webkit.org/show_bug.cgi?id=59143

        Respect the interface change in FrameLoaderClient.

        * WebCoreSupport/FrameLoaderClientGtk.cpp:
        (WebKit::FrameLoaderClient::dispatchDidChangeIcons):
        * WebCoreSupport/FrameLoaderClientGtk.h:
2011-05-04  Tao Bai  <michaelbai@chromium.org>

        Reviewed by David Kilzer.

        Populate touch-icon url to FrameLoaderClient
        https://bugs.webkit.org/show_bug.cgi?id=59143

        Respect the interface change in FrameLoaderClient.

        * Configurations/FeatureDefines.xcconfig:
        * WebCoreSupport/WebFrameLoaderClient.h:
        * WebCoreSupport/WebFrameLoaderClient.mm:
        (WebFrameLoaderClient::dispatchDidChangeIcons):
2011-05-04  Tao Bai  <michaelbai@chromium.org>

        Reviewed by David Kilzer.

        Populate touch-icon url to FrameLoaderClient
        https://bugs.webkit.org/show_bug.cgi?id=59143

        Respect the interface change in FrameLoaderClient.

        * WebCoreSupport/FrameLoaderClientQt.cpp:
        (WebCore::FrameLoaderClientQt::dispatchDidChangeIcons):
        * WebCoreSupport/FrameLoaderClientQt.h:
2011-05-04  Tao Bai  <michaelbai@chromium.org>

        Reviewed by David Kilzer.

        Populate touch-icon url to FrameLoaderClient
        https://bugs.webkit.org/show_bug.cgi?id=59143

        Respect the interface change in FrameLoaderClient.

        * WebCoreSupport/WebFrameLoaderClient.cpp:
        (WebFrameLoaderClient::dispatchDidChangeIcons):
        * WebCoreSupport/WebFrameLoaderClient.h:
2011-05-04  Tao Bai  <michaelbai@chromium.org>

        Reviewed by David Kilzer.

        Populate touch-icon url to FrameLoaderClient
        https://bugs.webkit.org/show_bug.cgi?id=59143

        Respect the interface change in FrameLoaderClient.

        * WebCoreSupport/FrameLoaderClientWinCE.cpp:
        (WebKit::FrameLoaderClientWinCE::dispatchDidChangeIcons):
        * WebCoreSupport/FrameLoaderClientWinCE.h:
2011-05-04  Tao Bai  <michaelbai@chromium.org>

        Reviewed by David Kilzer.

        Populate touch-icon url to FrameLoaderClient
        https://bugs.webkit.org/show_bug.cgi?id=59143

        Respect the interface change in FrameLoaderClient.

        * WebKitSupport/FrameLoaderClientWx.cpp:
        (WebCore::FrameLoaderClientWx::dispatchDidChangeIcons):
        * WebKitSupport/FrameLoaderClientWx.h:
2011-05-04  Tao Bai  <michaelbai@chromium.org>

        Reviewed by David Kilzer.

        Populate touch-icon url to FrameLoaderClient
        https://bugs.webkit.org/show_bug.cgi?id=59143

        Respected the change of FrameLoaderClient.
        Added WebIconURL and WebIconType responding the new IconURL and IconType.
        Supported to get the multiple icon urls.

        * Configurations/FeatureDefines.xcconfig:
        * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
        (WebKit::WebFrameLoaderClient::dispatchDidChangeIcons):
        * WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
2011-05-04  Tao Bai  <michaelbai@chromium.org>

        Reviewed by David Kilzer.

        Populate touch-icon url to FrameLoaderClient
        https://bugs.webkit.org/show_bug.cgi?id=59143

        Disable touch icon by default.

        * Scripts/build-webkit:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@85785 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2011-05-04  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Make the EWS test logging less verbose
        https://bugs.webkit.org/show_bug.cgi?id=60201

        This should help us generate less than a hundred MB of logs per hour.

        * Scripts/webkitpy/common/config/ports.py:
        * Scripts/webkitpy/common/config/ports_unittest.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@85786 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2011-05-04  Nate Chapin  <japhet@chromium.org>

        Reviewed by Mihai Parparita.

        Ensure we don't overwrite user-specified scroll positions
        on same document HistoryItem navigations.
        https://bugs.webkit.org/show_bug.cgi?id=59877

        * src/WebFrameImpl.cpp:
        (WebKit::WebFrameImpl::loadHistoryItem):
        (WebKit::WebFrameImpl::currentHistoryItem):
        (WebKit::WebFrameImpl::WebFrameImpl):
        * src/WebFrameImpl.h:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@85787 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2011-05-04  Rob Buis  <rbuis@rim.com>

        Reviewed by Darin Adler.

        NULL deref when SVG elements have table styles
        https://bugs.webkit.org/show_bug.cgi?id=45561

        Restrict computed CSS values for SVG display property to block, inline or none.

        Tests: svg/custom/display-table-caption-foreignObject.svg
               svg/custom/display-table-caption-inherit-foreignObject.xhtml
               svg/custom/display-table-caption-inherit-text.xhtml
               svg/custom/display-table-caption-text.svg

        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::applyProperty):



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@85788 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2011-05-04  Alexis Menard  <alexis.menard@openbossa.org>

        Reviewed by Adam Barth.

        Warning fix.

        * bindings/js/DOMObjectHashTableMap.h:
        (WebCore::DOMObjectHashTableMap::~DOMObjectHashTableMap):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@85789 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2011-05-04  Dimitri Glazkov  <dglazkov@chromium.org>

        Sort xcodeproj files.

        The WebCore.xcodeproj got out of sorts again.

        * WebCore.xcodeproj/project.pbxproj: Ran sort-XCode-project-file.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@85790 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2011-05-04  Alexis Menard  <alexis.menard@openbossa.org>

        Unreviewed warning fix.

        The variable is just used in the ASSERT macro. Let's use ASSERT_UNUSED to avoid
        a warning in Release build.

        * accessibility/AccessibilityRenderObject.cpp:
        (WebCore::lastChildConsideringContinuation):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@85791 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2011-05-04  Eric Seidel  <eric@webkit.org>

        Reviewed by Ojan Vafai.

        sheriff-bot can't parse results.html
        https://bugs.webkit.org/show_bug.cgi?id=60196

        The problem was that the NRWT bots are currently core
        and so sheriff-bot was trying to diagnose failures on
        them.  It was trying to parse their results.html file
        and BeautifulSoup was throwing an exception.

        It seems our version of BeautifulSoup was quite old
        and unable to handle <script> tags correctly.
        This moves us to 3.2 which doesn't seem to have this bug.

        * Scripts/webkitpy/thirdparty/BeautifulSoup.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@85792 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2011-05-04  Martin Robinson  <mrobinson@igalia.com>

        Fix the WebKitGTK+ build.

        * configure.ac: Added option parsing code for loading touch icons.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@85793 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2011-05-04  Anders Carlsson  <andersca@apple.com>

        Reviewed by Adam Roben.

        WKView on Windows has no equivalent of Mac's -[WKView setDraws[Transparent]Background:]
        https://bugs.webkit.org/show_bug.cgi?id=52009
        <rdar://problem/8829746>

        Add and implement WKViewSetDrawsTransparentBackground on windows.

        * UIProcess/API/C/win/WKView.cpp:
        (WKViewSetDrawsTransparentBackground):
        (WKViewDrawsTransparentBackground):
        Call through to the WebPageProxy object.

        * UIProcess/API/C/win/WKView.h:
        * UIProcess/win/WebView.cpp:
        (WebKit::drawPageBackground):
        Don't fill the rect with white if WebPageProxy::drawsBackground() or 
        WebPageProxy::drawsTransparentBackground() returns false. Because of limitations in Win32,
        both drawsBackground and drawsTransparentBackground are pretty much equivalent.

        (WebKit::WebView::paint):
        Pass the WebPageProxy object to drawPageBackground.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@85794 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Clip and reposition windowed plugins when the UI process paints

This ensures that their geometry updates in sync with the rest of the page.

Most of this patch is just plumbing the scheduleWindowedPluginGeometryUpdate and
scheduleChildWindowGeometryUpdate calls through from NetscapePlugin all the way over to
WebView. I've tried to call out the other parts below.

Fixes <http://webkit.org/b/60210> <rdar://problem/8483441> REGRESSION (WebKit2): Windowed
plugins don't scroll at the same speed as the rest of the page

Reviewed by Darin Adler and Anders Carlsson.

* UIProcess/PageClient.h:
* UIProcess/WebPageProxy.h:
* UIProcess/WebPageProxy.messages.in:
* UIProcess/win/WebPageProxyWin.cpp:
(WebKit::WebPageProxy::scheduleChildWindowGeometryUpdate):
Added plumbing.

* UIProcess/win/WebView.cpp:
(WebKit::WebView::onPaintEvent): Update child windows before painting so that they will stay
in sync with the rest of the page.
(WebKit::WebView::scheduleChildWindowGeometryUpdate): Add this update information to the
set of geometries to update on the next paint.
(WebKit::setWindowRegion): Moved this helper function here from NetscapePluginWin.cpp.
(WebKit::WebView::updateChildWindowGeometries): Update the size, position, and clip rects of
all the child windows with scheduled geometry updates.

* UIProcess/win/WebView.h: Added new members to track and update child window geometries.

* WebProcess/Plugins/Netscape/win/NetscapePluginWin.cpp:
(WebKit::NetscapePlugin::platformPostInitialize): Don't show the window immediately. Let the
UI process take care of it.
(WebKit::NetscapePlugin::platformGeometryDidChange): Don't update the window's position or
clip rect. Let the UI process take care of it.

* WebProcess/Plugins/PluginController.h:
* WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::scheduleWindowedPluginGeometryUpdate):
* WebProcess/Plugins/PluginView.h:
* WebProcess/WebPage/WebPage.h:
* WebProcess/WebPage/win/WebPageWin.cpp:
(WebKit::WebPage::scheduleChildWindowGeometryUpdate):
Added plumbing.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@85795 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2011-05-04  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Eric Seidel.

        [results.html] fix apply options on page load
        https://bugs.webkit.org/show_bug.cgi?id=60217

        This broke when we started storing options in localstorage.
        Also fixes regressions exposed by fixing this.

        * fast/harness/resources/results-test.js:
        * fast/harness/results.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@85796 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2011-05-04  James Kozianski  <koz@chromium.org>

        Reviewed by Eric Seidel.

        Add method to make a Port able to retrieve TestOutputSets from its builders.
        https://bugs.webkit.org/show_bug.cgi?id=58211

        This will be used in the new rebaseline script - TestOutputs are
        potential new baselines.

        * Scripts/webkitpy/common/config/urls.py:
        * Scripts/webkitpy/layout_tests/port/base.py:
        * Scripts/webkitpy/layout_tests/port/chromium.py:
        * Scripts/webkitpy/layout_tests/port/factory.py:
        * Scripts/webkitpy/layout_tests/port/webkit.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@85797 268f45cc-cd09-0410-ab3c-d52691b4dbfc