Bart,

Looks like my pull request is screwed up.  It turns out in my production
system where I did the original testing/profiling, I also have a global
lazyUpdate function that was being called (my original optimization), and
not the function in the SVG class, which doesn't work because of a
search/replace error.  I'll make the right changes, test it in an clean
environment and send a new pull request.

Cheers,

Bob


On Thu, Jan 23, 2014 at 4:29 AM, Bart van den Eijnden <
notifications@github.com> wrote:

> In lib/OpenLayers/Renderer/SVG.js:
>
> > @@ -222,6 +222,24 @@ OpenLayers.Renderer.SVG = OpenLayers.Class(OpenLayers.Renderer.Elements, {
> >          return nodeType;
> >      },
> >
> > +	 /**
> > +     * Method: lazyUpdate
> > +     * Only update the SVG attributes of a node if they are different     *
> > +     *
> > +     * Parameters:
> > +     * node - {SVGDomElement} An SVG element to decorate
> > +	 * ns- {SVGDomNamespace} The namespace of the attribute, null is
> > +	  *  an acceptable input if there is no namespace
> > +     * variable - {String} Attribute name
> > +     * newVal - {Object} The new value to set the attribute to
> > +     */
> > +
> > +	lazyUpdate: function(node, ns, variable, newVal) {
> > +	   if (node.getAttributeNS(ns, variable) != newVal) {
> > +		  lazyUpdate(node, ns, variable, newVal);
>
> this code means that setAttributeNS will never get called? Unless I'm
> missing something obvious here.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/openlayers/openlayers/pull/1228/files#r9106851>
> .
>