Top navigation improvements

- Improve services menu accessibility.
- Change the toggle behaviour of the services menu to be consistent with other header popup menus.
Even in new IEs? :o

It could be quite confusing if you click the drop down menu, refresh, and
then you're taken to the bottom of the page.

Oliver Joseph Ash
Software Engineer


On 21 July 2014 11:17, Kaelig <notifications@github.com> wrote:

> In common/app/views/fragments/topNav/servicesLinks.scala.html:
>
> > @@ -15,11 +15,12 @@
> >                  <a class="guardian-services__action" data-link-name="topNav : soulmates"
> >                     href="https://soulmates.theguardian.com/?INTCMP=NGW_TOPNAV_UK_GU_SOULMATES">soulmates</a>
> >              </div>
> > -            <div class="top-nav__item guardian-services__item-more--collapsed">
> > -                <span class="guardian-services__action js-services-nav-toggle" data-link-name="topNav : more">
> > +            <div class="top-nav__item guardian-services__item-more is-off">
> > +                <a href="#services" class="guardian-services__action"
>
> We were just looking into having an anchor for #services at the bottom of
> the page, actually (as a noscript fallback).
>
> buttons are a pain because when clicking them in all IEs, there is a
> 1-2px offset. And that's not the experience we want.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/guardian/frontend/pull/5124/files#r15161909>.
>

-- 

------------------------------
Visit theguardian.com. On your mobile and tablet, download the Guardian 
iPhone and Android apps theguardian.com/guardianapp and our tablet editions 
theguardian.com/editions.  Save up to 57% by subscribing to the Guardian 
and Observer - choose the papers you want and get full digital access. 
 Visit subscribe.theguardian.com

This e-mail and all attachments are confidential and may also be 
privileged. If you are not the named recipient, please notify the sender 
and delete the e-mail and all attachments immediately. Do not disclose the 
contents to another person. You may not use the information for any 
purpose, or store, or copy, it in any way.  Guardian News & Media Limited 
is not liable for any computer viruses or other material transmitted with 
or as part of this e-mail. You should employ virus checking software.
 
Guardian News & Media Limited is a member of Guardian Media Group plc. Registered 
Office: PO Box 68164, Kings Place, 90 York Way, London, N1P 2AP.  Registered 
in England Number 908396