gbproxy/test: Add expect_msg checks to test_gbproxy_keep_info (TODO)

This patch adds assertions to check the LLC/GMM message received from
the gbproxy by the test framework within the function
test_gbproxy_keep_info.

It also fixes the source address of the DETACH ACC messages.

TODO:
 - more tests

Sponsored-by: On-Waves ehf
gbproxy: Patch BSSGP P-TMSI in PAGING PS messages (TODO)

TODO:
  - commit message
  - finish test case

Sponsored-by: On-Waves ehf
sgsn: Added TODOs (TODO)

TODO:
  - fix and remove TODOs
  - remove this commit

Sponsored-by: On-Waves ehf
Revert "libgb/gprs: don't use log_info from libcommon anymore"

This reverts commit 11461a64574314fbc4747fe6251ca000fdd56b75.

This is causing crashes as soon as the VTY is used. Debugged by
Katerina and spotted by the customer and during VTY testing.

Conflicts:
	openbsc/include/osmocom/gprs/gprs_msgb.h
	openbsc/src/gprs/sgsn_main.c
	openbsc/src/libgb/common_vty.c
debian: Add a changelog entry for the OSMUX packages
update
bump the version once more
bump the version number
debian: Prepare new releases
debian: New release time.. rebased, merged, SGSN fixes
sgsn: Do not die in _bssgp_tx_dl_ud on TLLI mismatch (TODO)

Currently an OSMO_ASSERT fails, if the message's and the mmctx's
TLLIs do not match.

This commit turns the assertion into an ERROR log message and uses
the default values for IMSI, DRX, and RA CAP instead of the MM
context values in this case.

TODO:
  - find the real source for the problem
  - add test cases derived from what is being described in the ticket

Ticket: OW#1322
Sponsored-by: On-Waves ehf
sgsn: Cancel pending timer in sgsn_mm_ctx_free

Currently the timer is not stopped before the MM context is freed
which can lead to failure if sgsn_mm_ctx_free is called while timer
protected procedures are active.

This patch add code to cancel the timer if necessary from within
sgsn_mm_ctx_free.

Ticket: OW#1322
Sponsored-by: On-Waves ehf
gbproxy/test: Add test case for repeated and otherwise bad messages

This adds a test case to check gbproxy's behaviour when processing
two subsequent but identical Attach Accept messages.

Ticket: OW#1322
Sponsored-by: On-Waves ehf
gbproxy: Fix P-TMSI generation for repeated Attach Accept messages

Currently, when P-TMSI patching is enabled, a new BSS P-TMSI is
generated for each Attach Accept. So two duplicated, subsequent
Attach Accept messages will be mapped to different BSS side P-TMSI.
Because the last one will replace former ones in the link_info
struct, the MS will fail to access the SGSN if it uses the former
P-TMSI to derive the new TLLI.

This patch checks the SGSN P-TMSI already assigned to the link_info
and only generates a new BSS P-TMSI on mismatch (or if the BSS P-TMSI
hasn't been set yet).

Ticket: OW#1322
Sponsored-by: On-Waves ehf
gbproxy: Fix segfault for VTY delete-gbproxy-link

Currently the code segfaults when the link shall be deleted by IMSI
when the IMSI has not been set yet.

This patch adds a NULL check to skip the entry before calling
gsm48_mi_to_string,

Adresses:
Program received signal SIGSEGV, Segmentation fault.
0xb693af77 in gsm48_mi_to_string (string=0xbfffe020 "", str_len=200,
mi=0x0, mi_len=0) at gsm48.c:360
    360         mi_type = mi[0] & GSM_MI_TYPE_MASK;
    str_len=200, mi=0x0, mi_len=0) at gsm48.c:360
    self=0x807c9a0 <delete_gb_link_by_id_cmd>, vty=0xb4303c70,
     argc=3, argv=0xbfffe1c0) at gb_proxy_vty.c:670
...

Sponsored-by: On-Waves ehf
gbproxy: Patch BSSGP P-TMSI in PAGING PS messages (TODO)

Currently the P-TMSI IE in PAGING_PS is not patched.

This commit adds code the patch BSSGP P-TMSI IE in
gbproxy_patch_bssgp independently from the P-TMSI patching at the LLC
layer.

TODO:
  - finish test case

Sponsored-by: On-Waves ehf
sgsn: Only send Detach Accept (MO) if power_off isn't set (TODO)

Currently, every time the SGSN received a Detach Request from the MS
via an established logical link, it is answered by a Detach Accept.
This violates the specification (GSM 04.08, 4.7.4.1.2 and .3), which
states, that it should only be sent, if "the detach type IE value
indicates that the detach request has not been sent due to switching
off".

This patch adds a conditional to limit the sending of Detach Accept
accordingly.

TODO:
  - add test

Sponsored-by: On-Waves ehf
sgsn: Added TODOs (TODO)

TODO:
  - fix and remove TODOs
  - add test cases for Detach(power_off)
  - add test cases for Detach(reattach)
  - add test cases for PDP context deletion (OW#1311)
  - add test cases for Fix P-TMSI generation for repeated Attach Accept
    messages (OW#1322)
  - add test cases for Cancel pending timer in sgsn_mm_ctx_free
  - remove this commit

Sponsored-by: On-Waves ehf
Merge remote-tracking branch 'origin/jerlbeck/wip/gprs-patching' into je/packages/wip

Conflicts:
	openbsc/src/gprs/gprs_gmm.c
	openbsc/tests/gbproxy/gbproxy_test.c
debian: Prepare new test release (0.13.1+z8c)